[Schema Registry Avro] Support backward compatibility for old preamble format #20091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
conniey,
ramya-rao-a,
JoshLove-msft and
swathipil
ghost
added
the
sdk/schemaregistry/schema-registry-avro/src/schemaRegistryAvroEncoder.ts
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Jan 27, 2022
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jan 28, 2022
…e format (Azure#20091) * [Schema Registry Avro] Support backward compatibility for old preamble format * fix linting * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20063
The encoder used to return encoded data in a preamble format but that is about to change in the next release where messages will be returned instead with payload contains the pure encoded data. This PR adds support for decoding payloads that have been encoded in the old preamble format.