Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sort-imports] enforce sort-imports rule in core-auth #20002

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

bzhang0
Copy link
Contributor

@bzhang0 bzhang0 commented Jan 23, 2022

This PR reinforces the changes made in #19035 by changing the subdirectory's linting rule to "sort-imports": "error".

This affects the directory under sdk/core/core-auth.

@ghost ghost added Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 23, 2022
@ghost
Copy link

ghost commented Jan 23, 2022

Thank you for your contribution bzhang0! We will review the pull request and get back to you soon.

@ghost ghost added the Impact++ This pull request was submitted by a member of the Impact++ team. label Jan 23, 2022
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR!

@jeremymeng jeremymeng merged commit ee44eda into Azure:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. Impact++ This pull request was submitted by a member of the Impact++ team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants