Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPH] Clean up logs that use >>>> #19378

Merged
1 commit merged into from
Dec 15, 2021
Merged

[EPH] Clean up logs that use >>>> #19378

1 commit merged into from
Dec 15, 2021

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Dec 15, 2021

Resolves #19360

This PR cleans up the logs in the test files in the @azure/event-processor-host package to address the concerns brought up in #19360 around >>>>> being the same as git conflict markers.

I am using the prefix Test logs instead to differentiate these logs from the logs coming from the actual client code unless we are logging errors

Please note that the @azure/event-processor-host package is actually deprecated at this moment

@ghost
Copy link

ghost commented Dec 15, 2021

Hello @ramya-rao-a!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@witemple-msft witemple-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes my tools much happier.

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ghost ghost merged commit ae4c1d8 into Azure:main Dec 15, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[event-processor-host] debug logs in EPH look like conflict markers.
4 participants