Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[communication-short-codes] Migrate to Core v2 #19043

Merged
merged 37 commits into from
Mar 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
1c268fa
changes to migrate http client
AlonsoMondal Nov 12, 2021
c5628a6
shortcodes-http
AlonsoMondal Nov 30, 2021
396ac9d
formatting changes
AlonsoMondal Dec 8, 2021
241dcea
fixing from pulling
AlonsoMondal Dec 8, 2021
deaa203
formatting
AlonsoMondal Dec 8, 2021
3cd9851
credential changes for http client v2 migration
AlonsoMondal Dec 15, 2021
7e1b305
adding browser specific utils for auth
AlonsoMondal Dec 15, 2021
771553d
adding linter fixes
AlonsoMondal Dec 15, 2021
2155635
fixing mocked client
AlonsoMondal Dec 15, 2021
21025f0
updating policy and sdk version constant
AlonsoMondal Dec 15, 2021
a373479
formatting....
AlonsoMondal Dec 15, 2021
2493d46
re-recording node tests
AlonsoMondal Dec 15, 2021
5d36dda
fixes needed for browser tests
AlonsoMondal Dec 20, 2021
d9ad557
re-recording tests
AlonsoMondal Dec 20, 2021
1044fdd
fixing unsupported ES2020 'OptionalChain' syntax
AlonsoMondal Dec 21, 2021
b637f2b
formatting
AlonsoMondal Dec 21, 2021
f4a419e
fixing unsupported ES2020 'OptionalChain' syntax on pending sample
AlonsoMondal Dec 21, 2021
19fd6c5
fixing unsupported ES2020 'OptionalChain' syntax
AlonsoMondal Dec 21, 2021
64a2444
fixed typo for shortcodes description
AlonsoMondal Dec 22, 2021
bf1f4af
retaking http migration work
AlonsoMondal Dec 30, 2021
5491cd3
removing unnecessary file
AlonsoMondal Dec 30, 2021
bf51e18
removing http-core library
AlonsoMondal Jan 3, 2022
cd42244
resolving comments
AlonsoMondal Jan 4, 2022
98e83e9
adding re recorded tests
AlonsoMondal Jan 4, 2022
3bcbcda
resolving comments and re-recording tests
AlonsoMondal Jan 4, 2022
ecd8cfa
removing unsupported chainings in samples
AlonsoMondal Jan 4, 2022
fc8cb1f
fixing samples for ES2020 unsupported syntax
AlonsoMondal Jan 4, 2022
a10fc9a
formatting
AlonsoMondal Jan 4, 2022
b549cd0
fixing samples and rerecording tests
AlonsoMondal Jan 4, 2022
c6d249a
fixing tests to include azure on user agent.
AlonsoMondal Jan 18, 2022
99a1f79
fixing error from sms. formatting.
AlonsoMondal Feb 15, 2022
e9ec64c
Update communication-common dependency to 2.0.0
danielortega-msft Mar 8, 2022
183ab96
Reuse auth pipelines from communication-common
danielortega-msft Mar 10, 2022
a154fe5
Cleanup no longer needed dependencies
danielortega-msft Mar 10, 2022
f2bb065
Lint and format
danielortega-msft Mar 10, 2022
cf46b85
Expect `preferredVanityNumbers` in program briefs
danielortega-msft Mar 10, 2022
48337ff
Address PR comments
danielortega-msft Mar 11, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions sdk/communication/communication-short-codes/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
# Release History

## 1.0.0-beta.2 (Unreleased)

## 1.0.0-beta.2 (2022-02-08)
### Features Added
- Migrated from using `@azure/core-http` to `@azure/core-rest-pipeline` for the handling of HTTP requests. See [Azure Core v1 vs v2](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-rest-pipeline/documentation/core2.md) for more on the difference and benefits of the move.

### Breaking Changes

### Bugs Fixed

### Other Changes
- `ShortCodesClient.submitUSProgramBrief` no longer returns the generic `RestResponse` type, and instead returns the more specific `USProgramBrief`. Because of this, the `_response` property is no longer exposed in the returned object. However, in the operation options, it can take a callback (`onResponse`) to access the HTTP response. See https://github.com/Azure/autorest.typescript/wiki/%60core-http%60-dependency-migration-to-%60core-client%60-%60core-rest-pipeline%60#change-to-the-_response-property

## 1.0.0-beta.1 (2021-11-05)

Expand Down
23 changes: 20 additions & 3 deletions sdk/communication/communication-short-codes/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@azure-tools/communication-short-codes",
"version": "1.0.0-beta.2",
"description": "SDK for Azure Communication Services which facilitates short code management.\"",
"description": "SDK for Azure Communication Services which facilitates short code management.",
"sdk-type": "client",
"main": "dist/index.js",
"module": "dist-esm/src/index.js",
Expand Down Expand Up @@ -59,12 +59,13 @@
"sideEffects": false,
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
"dependencies": {
"@azure/communication-common": "^1.1.0",
"@azure/abort-controller": "^1.0.0",
"@azure/communication-common": "^2.0.0",
"@azure/core-auth": "^1.3.0",
"@azure/core-http": "^2.0.0",
"@azure/core-client": "^1.3.2",
"@azure/core-lro": "^2.2.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-rest-pipeline": "^1.3.2",
"@azure/core-tracing": "1.0.0-preview.13",
"@azure/logger": "^1.0.0",
"events": "^3.0.0",
Expand Down Expand Up @@ -107,6 +108,22 @@
"sinon": "^9.0.2",
"typescript": "~4.2.0"
},
"//metadata": {
"constantPaths": [
{
"path": "src/generated/src/shortCodesClientContext.ts",
"prefix": "packageDetails"
},
{
"path": "src/utils/constants.ts",
"prefix": "SDK_VERSION"
},
{
"path": "swagger/README.md",
"prefix": "package-version"
}
]
},
"//sampleConfiguration": {
"productName": "Azure Communication Services - Short Codes",
"productSlugs": [
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading