fix sample errors and update release CHANGELOG.md #18768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sajeetharan
commented
Nov 22, 2021
sajeetharan
commented
- Fix errors on samples with 'strict' mode ( cosmos/v3/typescript)
- Update CHANGELOG.md
sajeetharan
requested review from
jay-most,
kushagraThapar,
moderakh,
simorenoh,
simplynaveen20 and
xinlian12
as code owners
sdk/cosmosdb/cosmos/CHANGELOG.md
Outdated
| - Made several changes to the sample programs to improve code quality and compatibility with Node 12, and upgraded the sample programs' dependencies | ||
|
|
||
|
|
||
| ## 3.14.2 |
There was a problem hiding this comment.
Remove this whole 3.14.2 section.
sdk/cosmosdb/cosmos/CHANGELOG.md
Outdated
| ## 3.15.0 (Unreleased|2021-11-22) | ||
|
|
||
| ### Features Added | ||
| - Exported variables SasTokenPermissionKind and SasTokenProperties ,function createAuthorizationSasToken to demonstrate scoped access to Cosmos Resources with SasToken |
There was a problem hiding this comment.
Suggested change
| - Exported variables SasTokenPermissionKind and SasTokenProperties ,function createAuthorizationSasToken to demonstrate scoped access to Cosmos Resources with SasToken | |
| - Added the `SasTokenProperties` type and a `createAuthorizationSasToken` function to enable scoped access to Cosmos resources with SAS tokens. For an example that demonstrates creating a SAS token and using it to authenticate a `CosmosClient`, see [the `SasTokenAuth` sample](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/cosmosdb/cosmos/samples/v3/typescript/src/SasTokenAuth.ts). |
sdk/cosmosdb/cosmos/CHANGELOG.md
Outdated
| ### Other Changes | ||
| - Made several changes to the sample programs to improve code quality and compatibility with Node 12, and upgraded the sample programs' dependencies | ||
|
|
||
|
|
There was a problem hiding this comment.
Double check the spacing so there is only one blank line between sections.
sdk/cosmosdb/cosmos/CHANGELOG.md
Outdated
| - Exported variables SasTokenPermissionKind and SasTokenProperties ,function createAuthorizationSasToken to demonstrate scoped access to Cosmos Resources with SasToken | ||
|
|
||
| ### Other Changes | ||
| - Made several changes to the sample programs to improve code quality and compatibility with Node 12, and upgraded the sample programs' dependencies |
There was a problem hiding this comment.
Suggested change
| - Made several changes to the sample programs to improve code quality and compatibility with Node 12, and upgraded the sample programs' dependencies | |
| - Made several changes to the sample programs to improve code quality and compatibility with Node 12, and upgraded the sample programs' dependencies. |
sdk/cosmosdb/cosmos/CHANGELOG.md
Outdated
| @@ -1,6 +1,15 @@ | |||
| # Release History | |||
|
|
|||
| ## 3.14.2 (Unreleased) | |||
| ## 3.15.0 (Unreleased|2021-11-22) | |||
There was a problem hiding this comment.
Suggested change
| ## 3.15.0 (Unreleased|2021-11-22) | |
| ## 3.15.0 (2021-11-22) |
| - _GA_ Adds `container.item(itemId).patch()`. `patch()` is an alternative to `replace()` for item updates. https://github.com/Azure/azure-sdk-for-js/pull/16264/files#diff-7caca690c469e2025576523c0377ac71815f001024fde7c48b20cd24adaa6977R561 | ||
| - _GA_ support for Bulk operation PATCH. | ||
| - _GA_ support for Batch operation PATCH. | ||
| - Added the `SasTokenProperties` type and a `createAuthorizationSasToken` function to enable scoped access to Cosmos resources with SAS tokens. For an example that demonstrates creating a SAS token and using it to authenticate a `CosmosClient`, see [the `SasTokenAuth` sample](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/cosmosdb/cosmos/samples/v3/typescript/src/SasTokenAuth.ts). |
There was a problem hiding this comment.
Suggested change
| - Added the `SasTokenProperties` type and a `createAuthorizationSasToken` function to enable scoped access to Cosmos resources with SAS tokens. For an example that demonstrates creating a SAS token and using it to authenticate a `CosmosClient`, see [the `SasTokenAuth` sample](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/cosmosdb/cosmos/samples/v3/typescript/src/SasTokenAuth.ts). | |
| - Added the `SasTokenProperties` type and a `createAuthorizationSasToken` function to enable scoped access to Cosmos resources with SAS tokens. For an example that demonstrates creating a SAS token and using it to authenticate a `CosmosClient`, see [the `SasTokenAuth` sample](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/cosmosdb/cosmos/samples/v3/typescript/src/SasTokenAuth.ts). |
witemple-msft
approved these changes
Nov 22, 2021
kushagraThapar
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.