[KeyVault] - Use RBAC for permissions #18752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run js - keyvault-keys - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sadasant
approved these changes
Nov 20, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 29, 2022
Miceru/fix for automanage completeness (Azure#18752) * Add HybridCompute paths * Add AzureStackHci paths * fix spelling * formatting * formatting * fix LintDiff errors * fix LintDiff warnings * implemented collection GET for configurationProfileAssignments resources * fix LintDiff warnings * change description to NoContent * enable go track 2 pipeline Co-authored-by: ArcturusZhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Due to a recent permission that was added on the service side, our nightly tests
started failing as the ARM template has not been updated with the new
permission. Instead of adding the permissions, Heath noticed that we can switch
to RBAC roles now and avoid having to chase these things are they're added.
This commit just ports that over to Azure SDK for JS.