Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing naming for Download returning methods. #18703

Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes after merging
cochi2 committed Nov 16, 2021
commit ed2d34a8fc8f57c44ad696134393f5d509631008
Original file line number Diff line number Diff line change
@@ -6,7 +6,6 @@

import { AbortSignalLike } from '@azure/abort-controller';
import { CommunicationIdentifier } from '@azure/communication-common';
import * as coreHttp from '@azure/core-http';
import { OperationOptions } from '@azure/core-http';
import { OperationParameter } from '@azure/core-http';
import { PhoneNumberIdentifier } from '@azure/communication-common';
@@ -53,22 +52,6 @@ export interface CallConnection {
transfer(targetParticipant: CommunicationIdentifier, userToUserInformation: string, options?: TransferCallOptions): Promise<void>;
}

// @public
export type CallConnectionsAddParticipantResponse = AddParticipantResult & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: AddParticipantResult;
};
};

// @public
export type CallConnectionsPlayAudioResponse = PlayAudioResult & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: PlayAudioResult;
};
};

// @public
export type CallConnectionState = string;

@@ -318,14 +301,6 @@ export interface ServerCallLocatorKind extends ServerCallLocator {
kind: "serverCall";
}

// @public
export type ServerCallsAddParticipantResponse = AddParticipantResult & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: AddParticipantResult;
};
};

// @public
export interface StartCallRecordingResult {
recordingId?: string;
Original file line number Diff line number Diff line change
@@ -80,10 +80,7 @@ export class ContentDownloaderImpl implements ContentDownloader {
* @param contentUrl - The content Url.
* @param options - The options parameters.
*/
download_content(
contentUrl: string,
options?: OperationOptions
): Promise<ContentDownloadResult> {
download_content(contentUrl: string, options?: OperationOptions): Promise<ContentDownloadResult> {
const operationArguments: OperationArguments = {
options: operationOptionsToRequestOptionsBase(options || {})
};