Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve short codes live tests #18687

Merged
merged 6 commits into from
Nov 17, 2021

Conversation

ericasp16
Copy link
Member

Reorganize and improve the short codes live tests to be more robust and thoroughly check each endpoint. Improve logging/error checking/validation, etc

@ramya-rao-a
Copy link
Contributor

@ericasp16

Unrelated to this PR, but can you please add an entry to the codeowners file for this packege? See https://github.com/Azure/azure-sdk-for-js/blob/main/.github/CODEOWNERS#L36-L42. This will ensure that your PRs get labelled properly and get the right reviewers get looped in automatically

@ramya-rao-a
Copy link
Contributor

Another unrelated note to this PR, but related to this package is at #18688
Please take a look at that separately as well.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@AlonsoMondal AlonsoMondal merged commit 03ff1e0 into Azure:main Nov 17, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants