-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve short codes live tests #18687
Improve short codes live tests #18687
Conversation
…ricasp16/azure-sdk-for-js into ericasp/improve-short-codes-live-tests
Unrelated to this PR, but can you please add an entry to the codeowners file for this packege? See https://github.com/Azure/azure-sdk-for-js/blob/main/.github/CODEOWNERS#L36-L42. This will ensure that your PRs get labelled properly and get the right reviewers get looped in automatically |
Another unrelated note to this PR, but related to this package is at #18688 |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
update servicelinker enum name (Azure#18687)
Reorganize and improve the short codes live tests to be more robust and thoroughly check each endpoint. Improve logging/error checking/validation, etc