Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and test predefined set of packages only in identity pipelines #18686

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Build and test predefined set of packages only in identity pipelines #18686

merged 2 commits into from
Nov 15, 2021

Conversation

praveenkuttappan
Copy link
Member

Identity pipeline is timing out after 1 hour since it tries to build and test every packages in the repo.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Nov 15, 2021
@praveenkuttappan praveenkuttappan self-assigned this Nov 15, 2021
@praveenkuttappan
Copy link
Member Author

/azp run js - identity

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

sadasant
sadasant reviewed Nov 15, 2021
View reviewed changes
eng/tools/rush-runner.js Outdated Show resolved Hide resolved
sadasant
sadasant approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the list in this PR is good enough for now. We can fine-tune it over time.

@praveenkuttappan @sadasant
Update eng/tools/rush-runner.js
3196b1d 
Co-authored-by: Daniel Rodríguez <[email protected]>
@praveenkuttappan
Copy link
Member Author

/azp run js - identity

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Contributor

Fixes #18685

@praveenkuttappan praveenkuttappan merged commit 26ca5a7 into Azure:main Nov 15, 2021
@praveenkuttappan praveenkuttappan deleted the identity_build_set branch November 15, 2021 20:11
cochi2 added a commit that referenced this pull request Nov 15, 2021
@cochi2 @maorleger
@azure-sdk @benbp @scbedd @deyaaeldeen @chradek @sarangan12 @willmtemple @qiaozha @weshaggard @praveenkuttappan
Applying comments from API Review (#18662)
68337e8 
* Removing return response for Pause/Resume/Stop recording

* Removing validations

* Fixes after merge

* Added downloadToFile operation

* Added downloadToFile test

* Updating API MD file

* Fixing format auto

* Renaming files

* [KeyVault] - Move MHSM to resource group location (#18664)

Moving the Managed HSM to the same location as our resource group now that the
limits have been expanded.

* Add default cloud configuration values to source (#18653)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* simplify the commit history so that the patch can apply properly (#18665)

Co-authored-by: scbedd <[email protected]>

* Updating name for header

* [Event Hubs] Merge feature branch for buffered producer (#18590)

* [event-hubs] EventHubsBufferedProducerClient skeleton (#17761)

* temp transfer

* [event-hubs] initial EventHubBufferedProducerClient skeleton

* Change default value of BufferedCloseOptions.flush to true instead of false

* Reorder doc comment content for EventHubBufferedProducerClient

* remove eslint exception for @azure/azure-sdk/ts-naming-options in EventHubBufferedProducerClientOptions

* add enqueueEvent (singular) method

* update API view

* [WIP][event-hubs] EventHubBufferedProducerClient implementation (#18106)

* transfer

* [mock-hub] fix issue where calling stop() would not remove existing idle connection timeout watchers

* [event-hubs] reduce repetition in hubruntime.spec.ts tests

* Add support for flush,eventSuccess and eventError handlers, and backpressure to EventHubBufferedProducerClient

* add documentation and update API to align with .NET

* [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping (#18331)

* [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping

* fix the implementation

* factor out the hashing logic

* remove unused import

* the test pass but the implementation needs to be simplified

* simplified implementation

* address feedback

* address feedback

* fix format

* address feedback

Co-authored-by: chradek <[email protected]>

* [Event Hubs] Prepare release (#18672)

* [Event Hubs] Prepare release

* remove empty sections

* Node doesn't support some samples for smoke test (#18496)

* Node doesn't support some samples for smoke test

* [search-documents] reprocessed samples with exp. generator

Co-authored-by: Will Temple <[email protected]>

* Add rlc quickstart guideline (#18503)

* add llc quickstart guideline

* update format

* add documentation about ci.yml

* update to resolve some comments

* update to resolve some comments

* update to resolve comments

* updates term

* update format

* update format

* Running Rush update

* Sync eng/common directory with azure-sdk-tools for PR 2265 (#18683)

* Improve devops logging for link checker

* Update eng/common/scripts/Verify-Links.ps1

Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>

* Build and test predefined set of packages only in identity pipelines (#18686)

* Build and test predefined set of packages only in identity pipelines

* Fixing playback testing

* Run rushx format

Co-authored-by: Maor Leger <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: scbedd <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: chradek <[email protected]>
Co-authored-by: Sarangan Rajamanickam <[email protected]>
Co-authored-by: Will Temple <[email protected]>
Co-authored-by: Qiaoqiao Zhang <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: praveenkuttappan <[email protected]>
zihzhan-msft pushed a commit that referenced this pull request Nov 16, 2021
@cochi2 @maorleger
@azure-sdk @benbp @scbedd @deyaaeldeen @chradek @sarangan12 @willmtemple @qiaozha @weshaggard @praveenkuttappan
Fixing naming for Download returning methods. (#18703)
85893a8 
* [KeyVault] - Move MHSM to resource group location (#18664)

Moving the Managed HSM to the same location as our resource group now that the
limits have been expanded.

* Add default cloud configuration values to source (#18653)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* simplify the commit history so that the patch can apply properly (#18665)

Co-authored-by: scbedd <[email protected]>

* [Event Hubs] Merge feature branch for buffered producer (#18590)

* [event-hubs] EventHubsBufferedProducerClient skeleton (#17761)

* temp transfer

* [event-hubs] initial EventHubBufferedProducerClient skeleton

* Change default value of BufferedCloseOptions.flush to true instead of false

* Reorder doc comment content for EventHubBufferedProducerClient

* remove eslint exception for @azure/azure-sdk/ts-naming-options in EventHubBufferedProducerClientOptions

* add enqueueEvent (singular) method

* update API view

* [WIP][event-hubs] EventHubBufferedProducerClient implementation (#18106)

* transfer

* [mock-hub] fix issue where calling stop() would not remove existing idle connection timeout watchers

* [event-hubs] reduce repetition in hubruntime.spec.ts tests

* Add support for flush,eventSuccess and eventError handlers, and backpressure to EventHubBufferedProducerClient

* add documentation and update API to align with .NET

* [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping (#18331)

* [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping

* fix the implementation

* factor out the hashing logic

* remove unused import

* the test pass but the implementation needs to be simplified

* simplified implementation

* address feedback

* address feedback

* fix format

* address feedback

Co-authored-by: chradek <[email protected]>

* [Event Hubs] Prepare release (#18672)

* [Event Hubs] Prepare release

* remove empty sections

* Node doesn't support some samples for smoke test (#18496)

* Node doesn't support some samples for smoke test

* [search-documents] reprocessed samples with exp. generator

Co-authored-by: Will Temple <[email protected]>

* Add rlc quickstart guideline (#18503)

* add llc quickstart guideline

* update format

* add documentation about ci.yml

* update to resolve some comments

* update to resolve some comments

* update to resolve comments

* updates term

* update format

* update format

* Sync eng/common directory with azure-sdk-tools for PR 2265 (#18683)

* Improve devops logging for link checker

* Update eng/common/scripts/Verify-Links.ps1

Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>

* Build and test predefined set of packages only in identity pipelines (#18686)

* Build and test predefined set of packages only in identity pipelines

* Removed raw response from ContentDownloadResponse

* Changing name to RepeatanleContentDownloadResult

* Changed name to ContentDownloadResult

* Fixes after merging

Co-authored-by: Maor Leger <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: scbedd <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: chradek <[email protected]>
Co-authored-by: Sarangan Rajamanickam <[email protected]>
Co-authored-by: Will Temple <[email protected]>
Co-authored-by: Qiaoqiao Zhang <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: praveenkuttappan <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Apr 15, 2022
@ZeroMagic
CodeGen from PR 18686 in Azure/azure-rest-api-specs
7da4d7a 
Review request for Microsoft.ContainerService to add version 2022-03-01 (Azure#18686)

* Adds base for updating Microsoft.ContainerService from version stable/2022-02-01 to version 2022-03-01

* Updates readme

* Updates API version in new specs and examples

* Update readmes for the 2022-03-01 dev branch of container service (Azure#18357)

* update readme

* update sdk readmes

* feat: add ManagedCluster StorageProfile in 0301 (Azure#18594)

Signed-off-by: Ji An Liu <[email protected]>

* Replace common type definitions with references since 2022-03-01 for Microsoft.ContainerService (Azure#18568)

* replace Resource

* replacing systemData

* replace parameters

* fix: replace Resource with TrackedResource

* replace track2 with python

Co-authored-by: Ji'an Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

@sadasant sadasant sadasant approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

Assignees

@praveenkuttappan praveenkuttappan

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveenkuttappan @sadasant @mikeharder