Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARR samples to depend on Azure Identity 2.0.1 #18648

Merged
merged 4 commits into from
Nov 16, 2021
+17 −8
Merged

Update ARR samples to depend on Azure Identity 2.0.1 #18648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5534dda
Changes for identity 2.0.1
MalcolmTyrrell Nov 10, 2021
df0fc1f
Change README to match
MalcolmTyrrell Nov 10, 2021
ecf0b6d
Update changelog
MalcolmTyrrell Nov 11, 2021
a3eda4a
Changes to pnpm-lock file
MalcolmTyrrell Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions sdk/remoterendering/mixed-reality-remote-rendering/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release History

## 1.0.0-beta.2 (Unreleased)

- Update samples to depend on Azure Identity 2.0.1.

## 1.0.0-beta.1 (2021-09-21)

- Initial release.
7 changes: 5 additions & 2 deletions sdk/remoterendering/mixed-reality-remote-rendering/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,15 @@ const client = new RemoteRenderingClient(serviceEndpoint, accountId, accountDoma
Use the `DeviceCodeCredential` object to perform device code authentication.

```typescript Snippet:CreateAClientWithDeviceCode
let deviceCodeCallback = (deviceCodeInfo: DeviceCodeInfo) => {
const userPromptCallback = (deviceCodeInfo: DeviceCodeInfo) => {
console.debug(deviceCodeInfo.message);
console.log(deviceCodeInfo.message);
};

let credential = new DeviceCodeCredential(tenantId, clientId, deviceCodeCallback, {
const credential = new DeviceCodeCredential({
tenantId: tenantId,
clientId: clientId,
userPromptCallback: userPromptCallback,
authorityHost: "https://login.microsoftonline.com/" + tenantId
});

Expand Down
2 changes: 1 addition & 1 deletion sdk/remoterendering/mixed-reality-remote-rendering/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"devDependencies": {
"@azure/dev-tool": "^1.0.0",
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@azure/identity": "^1.1.0",
"@azure/identity": "^2.0.1",
"@azure-tools/test-recorder": "^1.0.0",
"@microsoft/api-extractor": "^7.18.11",
"@types/chai": "^4.1.6",
Expand Down
7 changes: 5 additions & 2 deletions sdk/remoterendering/mixed-reality-remote-rendering/samples-dev/moreComplexConversion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,15 @@ export function getClientWithAAD() {
}

export function getClientWithDeviceCode() {
const deviceCodeCallback = (deviceCodeInfo: DeviceCodeInfo) => {
const userPromptCallback = (deviceCodeInfo: DeviceCodeInfo) => {
console.debug(deviceCodeInfo.message);
console.log(deviceCodeInfo.message);
};

const credential = new DeviceCodeCredential(tenantId, clientId, deviceCodeCallback, {
const credential = new DeviceCodeCredential({
tenantId: tenantId,
clientId: clientId,
userPromptCallback: userPromptCallback,
authorityHost: "https://login.microsoftonline.com/" + tenantId
});

Expand Down