Feature/communication calling server preview #18462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/Azure/azure-sdk-for-js into feature/communication-CallingServer-preview
…/github.com/Azure/azure-sdk-for-js into feature/communication-CallingServer-preview
zihzhan-msft
requested review from
bterlson,
ramya-rao-a and
xirzec
as code owners
zihzhan-msft
requested review from
satyakonmsft
and removed request for
bterlson,
xirzec and
ramya-rao-a
downloadcontent class.
…e options parameter in JS SDK
…/github.com/Azure/azure-sdk-for-js into feature/communication-CallingServer-preview
|
API changes have been detected in API changes + exchangeTeamsToken(teamsToken: string, options?: OperationOptions): Promise<CommunicationAccessToken>;
- getTokenForTeamsUser(teamsUserAadToken: string, options?: OperationOptions): Promise<CommunicationAccessToken>; |
…/github.com/zihzhan-msft/azure-sdk-for-js into feature/communication-CallingServer-preview
…/github.com/zihzhan-msft/azure-sdk-for-js into feature/communication-CallingServer-preview
…/github.com/zihzhan-msft/azure-sdk-for-js into feature/communication-CallingServer-preview
cochi2
reviewed
Nov 2, 2021
Comment on lines
43
to
46
| download_content( | ||
| contentUri: string, | ||
| options?: OperationOptions | ||
| ): Promise<ContentDownloadResponse>; |
cochi2
reviewed
Nov 2, 2021
| /** | ||
| * The ContentDownloader interface represents related APIs. | ||
| */ | ||
| export interface ContentDownloader { |
There was a problem hiding this comment.
Could you please share why the interface is needed?
…/github.com/zihzhan-msft/azure-sdk-for-js into feature/communication-CallingServer-preview
zihzhan-msft
force-pushed
the
feature/communication-CallingServer-preview
branch
from
cc7e95c to
dd31b42
Compare
zihzhan-msft
merged commit 008b3be
into
Azure:feature/communication-CallingServer-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.