Common SDK version update in CallingServer SDK dependencies #18451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Nov 1, 2021
| @@ -68,7 +68,7 @@ | |||
| "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", | |||
| "dependencies": { | |||
| "@azure/abort-controller": "^1.0.0", | |||
| "@azure/communication-common": "^1.1.0", | |||
| "@azure/communication-common": "^1.1.1", | |||
There was a problem hiding this comment.
The usage of ^ will ensure that the customer gets the latest version of the common package among all the versions that have major version 1. Any reason to explicitly change this?
There was a problem hiding this comment.
Calling server SDK is dependent on the changes in common SDK from feature/communication-CallingServer-preview branch which is building using 1.1.1 version. Keeping 1.1.0 version causing the changes from feature branch are not reflecting in CallingServer SDK. Hope my understanding is correct.
There was a problem hiding this comment.
Additional information: Currently we are validating calling server SDK APIs in the end samples we have been developing.
zihzhan-msft
approved these changes
Nov 1, 2021
zihzhan-msft
merged commit 1984deb
into
Azure:feature/communication-CallingServer-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.