Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node.js 10 from test matrix #18403

Merged
merged 2 commits into from
Oct 29, 2021
+7 −7
Merged

Remove Node.js 10 from test matrix #18403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0794b8b
Remove Node.js 10 from test matrix
ramya-rao-a Oct 27, 2021
640ab7f
Fix text that has node version
ramya-rao-a Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eng/pipelines/templates/jobs/smoke.tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ jobs:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
ArmTemplateParameters: $(AzureCloudArmTemplateParameters)
NodeTestVersion: "16.x"
# Linux Node10 (AzureUSGovernment):
# Linux Node12 (AzureUSGovernment):
# Pool: Azure Pipelines
# OSVmImage: "ubuntu-18.04"
# SubscriptionConfiguration: $(sub-config-gov-test-resources)
# ArmTemplateParameters: $(AzureUSGovernmentArmTemplateParameters)
# NodeTestVersion: "10.x"
# NodeTestVersion: "12.x"
# Windows Node14 (AzureUSGovernment):
# Pool: Azure Pipelines
# OSVmImage: "windows-2019"
Expand All @@ -97,12 +97,12 @@ jobs:
# SubscriptionConfiguration: $(sub-config-cn-test-resources)
# ArmTemplateParameters: $(AzureChinaCloudArmTemplateParameters)
# NodeTestVersion: "12.x"
# Windows Node10 (AzureChinaCloud):
# Windows Node12 (AzureChinaCloud):
# Pool: Azure Pipelines
# OSVmImage: "windows-2019"
# SubscriptionConfiguration: $(sub-config-cn-test-resources)
# ArmTemplateParameters: $(AzureChinaCloudArmTemplateParameters)
# NodeTestVersion: "10.x"
# NodeTestVersion: "12.x"
ramya-rao-a marked this conversation as resolved.
Show resolved Hide resolved

pool:
name: $(Pool)
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/stages/platform-matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"Pool": "Azure Pipelines"
}
},
"NodeTestVersion": ["10.x", "12.x", "14.x", "16.x"],
"NodeTestVersion": ["12.x", "14.x", "16.x"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start testing Node 17 the same as we did with 15?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we do that at once for all packages the last time or try it for a few packages fix any issues and then applied it at this level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logged #18447 to track the addition of Node.js 17 to the test matrix and ensuring all tests pass

"TestType": "node",
"TestResultsFiles": "**/test-results.xml"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-admin/platform-matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
},
"TestType": "node",
"NodeTestVersion": "10.x"
"NodeTestVersion": "12.x"
}
]
}
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-keys/platform-matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
},
"TestType": "node",
"NodeTestVersion": "10.x"
"NodeTestVersion": "12.x"
},
{
"Agent": {
Expand Down