Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Core2 Migration #17045

Merged
merged 13 commits into from
Aug 25, 2021
Merged

Chat Core2 Migration #17045

merged 13 commits into from
Aug 25, 2021

Conversation

LuChen-Microsoft
Copy link
Member

No description provided.

@ramya-rao-a ramya-rao-a requested a review from sarangan12 August 24, 2021 18:15
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, but this looks good modulo feedback from reviewers! 👍

requestContentType: "application/json; charset=utf-8"
};

const packageDetails = `azsdk-js-azure-communication-chat/1.1.0-beta.1`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm should this say beta.2 now?

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You nailed it!

I wonder though if you did not have to re-record the tests but it is no big deal. I looked at a few and do not see major differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants