-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Core2 Migration #17045
Chat Core2 Migration #17045
Conversation
sdk/communication/communication-chat/test/public/utils/recordedClient.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nits, but this looks good modulo feedback from reviewers! 👍
sdk/communication/communication-chat/src/generated/src/chatApiClientContext.ts
Show resolved
Hide resolved
requestContentType: "application/json; charset=utf-8" | ||
}; | ||
|
||
const packageDetails = `azsdk-js-azure-communication-chat/1.1.0-beta.1`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm should this say beta.2
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You nailed it!
I wonder though if you did not have to re-record the tests but it is no big deal. I looked at a few and do not see major differences.
No description provided.