Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typings to types in clean NPM scripts #16965

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Update typings to types in clean NPM scripts #16965

merged 1 commit into from
Aug 19, 2021

Conversation

jeremymeng
Copy link
Member

  • Our convention now is to use types.
  • Some packages output type definition files into types directory but the clean scripts still use typings.

@jeremymeng
Update typings to types in clean NPM scripts
11bfd9c 
- Our convention now is to use `types`
@ramya-rao-a
Copy link
Contributor

@deyaaeldeen Is this caught by the linter? If not, can you log an issue for it?

@ramya-rao-a
Copy link
Contributor

@sarangan12 Is this something that should be updated in the code gen as well?

@sarangan12
Copy link
Contributor

@ramya-rao-a The clean script is not generated fully in the generator as of now. It is just echo skipped. But, when I actually update it to the correct format, I will include this.

@deyaaeldeen
Copy link
Member

@deyaaeldeen Is this caught by the linter? If not, can you log an issue for it?

@ramya-rao-a I created this epic #16979

@jeremymeng jeremymeng merged commit 799bdea into Azure:main Aug 19, 2021
@jeremymeng jeremymeng deleted the clean-command-typings-types branch August 19, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec approved these changes

@deyaaeldeen deyaaeldeen deyaaeldeen approved these changes

@HarshaNalluru HarshaNalluru HarshaNalluru approved these changes

@joheredi joheredi joheredi approved these changes

@chradek chradek Awaiting requested review from chradek

@ellismg ellismg Awaiting requested review from ellismg

@EmmaZhu EmmaZhu Awaiting requested review from EmmaZhu EmmaZhu is a code owner

@jiacfan jiacfan Awaiting requested review from jiacfan jiacfan is a code owner

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner

@ljian3377 ljian3377 Awaiting requested review from ljian3377 ljian3377 is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

@sadasant sadasant Awaiting requested review from sadasant

@sarangan12 sarangan12 Awaiting requested review from sarangan12

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@vinjiang vinjiang Awaiting requested review from vinjiang vinjiang is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu XiaoningLiu is a code owner

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration Azure.Identity Cognitive - Form Recognizer Cognitive - Metrics Advisor Cognitive - Text Analytics Event Grid KeyVault Search Storage Storage Service (Queues, Blobs, Files) Tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeremymeng @ramya-rao-a @sarangan12 @deyaaeldeen @xirzec @HarshaNalluru @joheredi