-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Analytics] Merge feature branch for v3.2-preview.1 #16716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Text Analytics] Add support for extract summary actions * add a test case * update readme * edit * edit * edit * regenerate using latest swagger * edit * edit * address feedback * edit * edit
deyaaeldeen
requested review from
kinelski,
maririos,
kristapratico,
iscai-msft and
mssfang
August 3, 2021 04:10
deyaaeldeen
requested review from
bterlson,
chradek,
witemple-msft and
xirzec
as code owners
August 3, 2021 04:10
ghost
added
the
Cognitive - Text Analytics
label
Aug 3, 2021
deyaaeldeen
requested review from
mikeharder and
praveenkuttappan
as code owners
August 3, 2021 17:46
/azp run js - textanalytics - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
deyaaeldeen
force-pushed
the
feature/textanalytics/3.2
branch
from
August 3, 2021 20:47
7a6b2e0
to
93de9ad
Compare
maririos
reviewed
Aug 3, 2021
@@ -252,7 +252,7 @@ export interface ExtractKeyPhrasesSuccessResult extends TextAnalyticsSuccessResu | |||
export interface ExtractSummaryAction extends TextAnalyticsAction { | |||
disableServiceLogs?: boolean; | |||
maxSentenceCount?: number; | |||
orderBy: string; | |||
orderBy?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
maririos
approved these changes
Aug 3, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 18, 2021
add 2021-05-01-preview/ServerConnectionPolicies.json to V5 SDK tag (Azure#16716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the feature branch for adding the support for extract summary actions. This branch has one unreviewed commit which has re-recordings of all tests: 143c35d
Fixes #16415.