Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for GA release #16619

Merged
merged 8 commits into from
Jul 29, 2021
Merged

Conversation

LarryOsterman
Copy link
Member

Prepare the attestation SDK for GA.

@deyaaeldeen
Copy link
Member

I noticed that some tests takes long time in playback mode, e.g. Add Policy Certificates failure conditions, is this expected?:
Found configuration in /home/dalmahal/attestation/rush.json

�[1mRush Multi-Project Build Tool 5.40.7�[22m�[36m - https://rushjs.io�[39m
Node.js version is 14.17.0 (LTS)

Found configuration in /home/dalmahal/attestation/rush.json

Executing: "mocha -r esm --require ts-node/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 1200000 --full-trace "test/{,!(browser)/**/}/*.spec.ts""

[AAD] Attestation Client
✓ #AttestOpenEnclaveShared (128ms)
✓ #AttestOpenEnclaveAad (49ms)
✓ #AttestOpenEnclaveIsolated
✓ #AttestSgxEnclaveShared
✓ #AttestSgxEnclaveAad
✓ #AttestSgxEnclaveIsolated
✓ #attestTpm (111ms)

AttestationTokenTests
✓ #testUtf8ConversionFunctions
✓ #createRsaSigningKey (4895ms)
✓ #createEcdsSigningKey (406ms)
✓ #createSigningKeyWrongKey (320ms)
✓ #createUnsecuredAttestationToken
✓ #createUnsecuredEmptyAttestationToken
✓ #createEmptySecuredAttestationToken (3132ms)
✓ #createSecuredAttestationToken (3075ms)
In callback, token algorithm: none
In callback, token algorithm: none
✓ #verifyAttestationTokenCallback
✓ #verifyAttestationTokenIssuer
✓ #verifyAttestationTimeouts

PolicyGetSetTests
✓ #GetPolicy SGX - Aad
✓ #GetPolicy SGX - Isolated
✓ #GetPolicy SGX - Shared
✓ Set Policy SGX - AAD Unsecured
✓ Set Policy failure conditions (5803ms)
✓ Reset Policy failure conditions (9385ms)
- Set Policy SGX - AAD Secured (secured APIs cannot match the policy hash because the recorded policy signer won't match the signer in the request)
- Set Policy SGX - Isolated Secured (setPolicy APIs require keys and certificates from the environment, which are not available in playback)
✓ Reset Policy SGX - AAD Unsecured
- Reset Policy SGX - AAD Secured (secured APIs cannot match the policy hash because the recorded policy signer won't match the signer in the request)
- Reset Policy SGX - Isolated Secured (resetPolicy APIs require keys and certificates from the environment, which are not available in playback)

PolicyManagementTests
✓ #getPolicyCertificates - AAD
✓ #getPolicyCertificates - Shared
✓ #getPolicyCertificates - Isolated
✓ Add Policy Certificates failure conditions (8894ms)
✓ Remove Policy failure conditions (2403ms)
- setPolicyCertificates (setPolicyCertificate APIs require keys and certificates from the environment, which are not available in playback)

TokenCertTests
✓ #GetCertificateAAD
✓ #GetCertificatesIsolated
✓ #GetCertificatesShared
✓ #GetMetadataConfigAAD
✓ #GetMetadataConfigIsolated
✓ #GetMetadataConfigShared

36 passing (39s)
5 pending

@LarryOsterman
Copy link
Member Author

LarryOsterman commented Jul 28, 2021

I noticed that some tests takes long time in playback mode, e.g. Add Policy Certificates failure conditions, is this expected?:
Found configuration in /home/dalmahal/attestation/rush.json

�[1mRush Multi-Project Build Tool 5.40.7�[22m�[36m - https://rushjs.io�[39m
Node.js version is 14.17.0 (LTS)

Found configuration in /home/dalmahal/attestation/rush.json

Executing: "mocha -r esm --require ts-node/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 1200000 --full-trace "test/{,!(browser)/**/}/*.spec.ts""

[AAD] Attestation Client
✓ #AttestOpenEnclaveShared (128ms)
✓ #AttestOpenEnclaveAad (49ms)
✓ #AttestOpenEnclaveIsolated
✓ #AttestSgxEnclaveShared
✓ #AttestSgxEnclaveAad
✓ #AttestSgxEnclaveIsolated
✓ #attestTpm (111ms)

AttestationTokenTests
✓ #testUtf8ConversionFunctions
✓ #createRsaSigningKey (4895ms)
✓ #createEcdsSigningKey (406ms)
✓ #createSigningKeyWrongKey (320ms)
✓ #createUnsecuredAttestationToken
✓ #createUnsecuredEmptyAttestationToken
✓ #createEmptySecuredAttestationToken (3132ms)
✓ #createSecuredAttestationToken (3075ms)
In callback, token algorithm: none
In callback, token algorithm: none
✓ #verifyAttestationTokenCallback
✓ #verifyAttestationTokenIssuer
✓ #verifyAttestationTimeouts

PolicyGetSetTests
✓ #GetPolicy SGX - Aad
✓ #GetPolicy SGX - Isolated
✓ #GetPolicy SGX - Shared
✓ Set Policy SGX - AAD Unsecured
✓ Set Policy failure conditions (5803ms)
✓ Reset Policy failure conditions (9385ms)

  • Set Policy SGX - AAD Secured (secured APIs cannot match the policy hash because the recorded policy signer won't match the signer in the request)
  • Set Policy SGX - Isolated Secured (setPolicy APIs require keys and certificates from the environment, which are not available in playback)
    ✓ Reset Policy SGX - AAD Unsecured
  • Reset Policy SGX - AAD Secured (secured APIs cannot match the policy hash because the recorded policy signer won't match the signer in the request)
  • Reset Policy SGX - Isolated Secured (resetPolicy APIs require keys and certificates from the environment, which are not available in playback)

PolicyManagementTests
✓ #getPolicyCertificates - AAD
✓ #getPolicyCertificates - Shared
✓ #getPolicyCertificates - Isolated
✓ Add Policy Certificates failure conditions (8894ms)
✓ Remove Policy failure conditions (2403ms)

  • setPolicyCertificates (setPolicyCertificate APIs require keys and certificates from the environment, which are not available in playback)

TokenCertTests
✓ #GetCertificateAAD
✓ #GetCertificatesIsolated
✓ #GetCertificatesShared
✓ #GetMetadataConfigAAD
✓ #GetMetadataConfigIsolated
✓ #GetMetadataConfigShared

36 passing (39s)
5 pending

JSRSASIGN is ridiculously slow generating 2K RSA keys. I'll change it ot generate 1K keys, which should improve performance - it goes down to 133ms on my machine.

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@LarryOsterman LarryOsterman merged commit 95487e0 into Azure:main Jul 29, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Dec 9, 2021
Microsoft.SecurityInsights 2021-09-01-preview (Azure#16933)

* Adds base for updating Microsoft.SecurityInsights from version preview/2021-03-01-preview to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* Microsoft.security insights 2021 09 01 preview add missing resources (Azure#15531)

* Copy missing resources specs and examples from 2019-01-01-preview

* Update added resources specs and examples and extract common types

* Update readme

* Extract ClientInfo, UserInfo and Lable to common types

* Fix SpellCheck and Avocado

* Return ThreatIntelligence to readme

* Fix broken refs in Watchlists

* Resolve duplicate schema errors

* Run prettier

* Make common types prettier

* Add required property to operations according to ARM requirments

* Fix readme

* Add file separators to readme

* Rename example file

* Supress OBJECT_ADDITIONAL_PROPERTIES

* Add 'where' to OBJECT_ADDITIONAL_PROPERTIES supression

* Move OBJECT_ADDITIONAL_PROPERTIES supression under general Supression section.

* Copy dataConnectors from 2021-03-01-preview

* Update version of dataConnectors (this was done as there were errors when trying to generate C# client. Copying and changing version again fixed the problem).

* Add dataConnectorsCheckRequirments path, parameters and definitions from 2019-01-01-preveiw

Co-authored-by: Anat Gilenson <[email protected]>

* Use newest common types in new 2021-09-01-preview API version (Azure#15778)

* Use newest common types in AlertRules

* Use newest common types in AutomationRules

* Use newest common types in Bookmarks

* Use newest common types in dataConnectors

* Use newest common types in Enrichment

* Use newest common types in Entities

* Use newest common types in EntityQueries

* Use newest common types in Incidents

* Use newest common types in Metadata

* Use newest common types in OfficeConsents

* Use newest common types in OnboardingStates

* Use newest common types in operations

* Use newest common types in Settings

* Use newest common types in SourceControls

* Use newest common types in ThreatIntelligence

* Use newest common types in Watchlist

* Use newest common types in EntityTypes

* Use newest common types in RelationTypes

* Fix ThreatIntelligence

Co-authored-by: Anat Gilenson <[email protected]>

* Add template version to the scheduled alert rule + scheduled template (Azure#15919)

* Add template version to the scheduled alert rule

* Update AlertRules.json

* Update AlertRules.json

* Update AlertRules.json

* Update AlertRules.json

* Update GetAlertRuleTemplates.json

* Update GetAlertRuleTemplateById.json

* add aws s3 connector (Azure#15844)

* Add a new kind of alert rules - NRT (Azure#15980)

* add NRT rule

* add NRT rule

* add NRT rule

* add NRT rule

* fix typo

* fix typo

* fix

* Align new Metadata feature with 2021-03-01-preview (Azure#16304)

Co-authored-by: Anat Gilenson <[email protected]>

* Add fixes from 2021-03-01-preview (Azure#16238)

Co-authored-by: Anat Gilenson <[email protected]>

* Add entity query templates (Azure#16269)

* Add entity query templates from 2021-03-01-preview

* Update version

* Use newest common types and update readme

* Fix conflicting common types

Co-authored-by: Anat Gilenson <[email protected]>

* Fix bookmark relations operatinIds to be consistent with other operationIds. (Azure#16519)

Co-authored-by: Anat Gilenson <[email protected]>

* Add corrections from 2021-03-01-preview (Azure#16490)

Co-authored-by: Anat Gilenson <[email protected]>

* Remove unused parameters (Azure#16619)

Co-authored-by: Anat Gilenson <[email protected]>

* Update readme default readme tag for client generation (Azure#16620)

Co-authored-by: Anat Gilenson <[email protected]>

* Use CloudError instead of ErrorResponse to avoid breaking change (Azure#16691)

Co-authored-by: Anat Gilenson <[email protected]>

* Add data connectors polling ccp api support (Azure#16293)

* adding dataConnectors polling CCP api Support. (witout tests validations)

* azure sentinel dataconnectors update examples

* azure sentinel dataConnectors examples update and fix

* azure sentinel dataConnectors prettier

* azure sentinel dataConnectors add connect disconnect examples update path

* azure sentinel dataConnectors add connect disconnect examples fix

* azure sentinel dataConnectors add connect disconnect examples fix 2

* azure sentinel dataConnectors rebase dataConnectors dev

* azure sentinel dataconnectors - fix put to post on connect and disconnect endpoints

* azure sentinel dataconnectors - adding x-ms-secret to password on connect

* azure sentinel dataconnectors - connect/disconnect endpoint remove unnedded 201 return

* azure sentinel dataConnectors - remove empty body DataConnectorDisconnectBody

Co-authored-by: Alon Danoch <[email protected]>

* Add office IRM Connector (Azure#16764)

* Add office IRM

* fix

* fix

* fix

* fix

Co-authored-by: omerhaimov <[email protected]>

* Add teamInformation to IncidentProperties 2021-09-01-preview (Azure#16787)

* Fix Swagger for SecurityInsights - Add teamInformation to IncidentProperties

* Try change description as advised by Swagger reviewer Yuchao Yan to fix the validation error.

* Revert change in ntDomain description as it has nothing to do with validations

Co-authored-by: Anat Gilenson <[email protected]>

* Make CloudError and CloudErrorBody external resources (already exist under Microsoft.Rest.Azure namespace) (Azure#16872)

Co-authored-by: Anat Gilenson <[email protected]>

* Remove operational insights parameter 2021 09 01 preview (Azure#16891)

* Remove operationalInsightsResourceProvider parameter from specs

* Remove parameter from examples

Co-authored-by: Anat Gilenson <[email protected]>

* Update EntityTypes.json (Azure#16972)

Co-authored-by: Anat Gilenson <[email protected]>
Co-authored-by: Amit Bergman <[email protected]>
Co-authored-by: sagamzu <[email protected]>
Co-authored-by: necoh <[email protected]>
Co-authored-by: alondanoch <[email protected]>
Co-authored-by: Alon Danoch <[email protected]>
Co-authored-by: omerhaimov <[email protected]>
Co-authored-by: omerhaimov <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants