Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Monitor Exporter] Add resource and outputs for ARM template to fix pipeline build #16390

Merged
merged 6 commits into from
Jul 15, 2021

Conversation

xiao-lix
Copy link
Contributor

No description provided.

@ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jul 14, 2021
@xiao-lix
Copy link
Contributor Author

/azp run js - monitor-opentelemetry-exporter - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiao-lix
Copy link
Contributor Author

/azp run js - monitor-opentelemetry-exporter - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiao-lix
Copy link
Contributor Author

/azp run js - monitor-opentelemetry-exporter - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiao-lix
Copy link
Contributor Author

/azp run js - monitor-opentelemetry-exporter - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -92,6 +93,16 @@
"principalId": "[parameters('testApplicationOid')]",
"scope": "[resourceGroup().id]"
}
},
{
"type": "Microsoft.Insights/components",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to create an Application Insights resource when you execute the tests?

@xiao-lix
Copy link
Contributor Author

/azp run js - monitor-opentelemetry-exporter - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this

@hectorhdzg hectorhdzg merged commit ee94883 into Azure:main Jul 15, 2021
deyaaeldeen pushed a commit that referenced this pull request Jul 26, 2021
… fix pipeline build (#16390)

* add resource and outputs for arm template

* fix

* update version

* fix pipeline

* stop server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants