Renamed any types to be unknown
#16344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryOsterman
requested review from
bterlson,
chradek,
deyaaeldeen and
xirzec
as code owners
deyaaeldeen
reviewed
Jul 9, 2021
| @@ -103,7 +103,7 @@ export interface AttestationResult { | |||
| * `runtimeJson` parameter to the `Attest` API is specified. It will | |||
| * not be populated if the `runtimeData` parameter is specified. | |||
| */ | |||
| runtimeClaims: any; | |||
| runTimeClaims: unknown; | |||
There was a problem hiding this comment.
runTime feels odd in comparison to runtime, did someone ask for this change?
There was a problem hiding this comment.
@xirzec asked me to change inittimeData to initTimeData. To be consistent in naming convention, I renamed runtimeData to match the pattern.
inittimeData is data which is presented at the time the enclave is initialized, runtimeData is data which is presented at the time that the evidence is created. The naming convention for both of these should be the same, IMHO since they are so closely related.
There was a problem hiding this comment.
Btw, initTime and runTime is also consistent with the AttestSgxEnclaveOptions/AttestOpenEnclaveOptions model types.
deyaaeldeen
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.