track2 @azure/arm-features #16207
track2 @azure/arm-features #16207
Conversation
dw511214992
requested review from
deyaaeldeen,
mikeharder,
mitchdenny,
praveenkuttappan,
qiaozha and
witemple-msft
as code owners
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| export type FeaturesUnregisterResponse = FeatureResult; | ||
|
|
||
| // @public | ||
| export const enum KnownSubscriptionFeatureRegistrationApprovalType { |
There was a problem hiding this comment.
Let's make sure all enums are just regular enums. Const enums do not work well in javascript: Azure/autorest.typescript#1013
There was a problem hiding this comment.
I think it's an important issue. @sarangan12 could you please fix it ASAP. I think it blocks the release.
There was a problem hiding this comment.
Created PR Azure/autorest.typescript#1097
| "sourceMap": true, | ||
| "declarationMap": true, | ||
| "esModuleInterop": true, | ||
| "allowSyntheticDefaultImports": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "lib": ["es6"], | ||
| "preserveConstEnums": true, | ||
| "lib": ["es6", "dom"], |
There was a problem hiding this comment.
In one of the data plane SDKs, this was creating issue. I do not remember which SDK. On analysis, I found this was generic and we should add the dom also. If you feel this is not required specifically for this SDK, you can remove it if there are no issues on your side.
There was a problem hiding this comment.
@witemple-msft and @xirzec what do you think about this?
There was a problem hiding this comment.
Better to omit it if your SDK doesn't only work in browsers, but sometimes it's hard to avoid. I'd need to see the build error.
There was a problem hiding this comment.
It should be fine to include as long as we're careful to shim browser types that are exposed in the API surface. I took a quick look through the api.md and didn't see anything that sticks out to me.
There was a problem hiding this comment.
This is emitted by code gen (@sarangan12 for all packages, right?) so I think we're careful in the sense that code gen does not understand browser types/shims anyway.
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # common/config/rush/pnpm-lock.yaml # rush.json
dw511214992
requested review from
ramya-rao-a,
deyaaeldeen and
lirenhe
and removed request for
mikeharder and
witemple-msft
# Conflicts: # common/config/rush/pnpm-lock.yaml
No description provided.