track2 @azure/arm-features #16207

dw511214992 · 2021-07-06T06:36:32Z

No description provided.

dw511214992 · 2021-07-06T06:37:22Z

/azp run prepare-pipelines

azure-pipelines · 2021-07-06T06:37:33Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/features/arm-features/CHANGELOG.md

deyaaeldeen · 2021-07-06T18:17:32Z

sdk/features/arm-features/review/arm-features.api.md

+export type FeaturesUnregisterResponse = FeatureResult;
+
+// @public
+export const enum KnownSubscriptionFeatureRegistrationApprovalType {


Let's make sure all enums are just regular enums. Const enums do not work well in javascript: Azure/autorest.typescript#1013

I think it's an important issue. @sarangan12 could you please fix it ASAP. I think it blocks the release.

Created PR Azure/autorest.typescript#1097

sdk/features/arm-features/CHANGELOG.md

deyaaeldeen · 2021-07-06T18:20:49Z

sdk/features/arm-features/tsconfig.json

    "sourceMap": true,
    "declarationMap": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "forceConsistentCasingInFileNames": true,
-    "lib": ["es6"],
+    "preserveConstEnums": true,
+    "lib": ["es6", "dom"],


why adding dom here?

@sarangan12

In one of the data plane SDKs, this was creating issue. I do not remember which SDK. On analysis, I found this was generic and we should add the dom also. If you feel this is not required specifically for this SDK, you can remove it if there are no issues on your side.

@witemple-msft and @xirzec what do you think about this?

Better to omit it if your SDK doesn't only work in browsers, but sometimes it's hard to avoid. I'd need to see the build error.

It should be fine to include as long as we're careful to shim browser types that are exposed in the API surface. I took a quick look through the api.md and didn't see anything that sticks out to me.

This is emitted by code gen (@sarangan12 for all packages, right?) so I think we're careful in the sense that code gen does not understand browser types/shims anyway.

sdk/features/arm-features/package.json

dw511214992 · 2021-07-07T05:21:17Z

/azp run prepare-pipelines

azure-pipelines · 2021-07-07T05:21:26Z

Azure Pipelines successfully started running 1 pipeline(s).

# Conflicts: # common/config/rush/pnpm-lock.yaml # rush.json

# Conflicts: # common/config/rush/pnpm-lock.yaml

Dev sql microsoft.sql 2021 05 01 preview release (Azure#16289) * add base for Microsoft.sql * Update Readme.md * update version in swagger example files * remove ss * update swagger files * update readme.md * add missing json files * update custom-words.txt to address the spelling check * remove 201 define in ServerUpdate.json * Sync sql 2021 05 01 with main branch (Azure#16236) * Update comment.yml for publish pr (Azure#16166) * Update comment.yml * Update comment.yml * Bump dependencies (Azure#16170) * bump avocado * bump mocha * remove submodule (Azure#16171) * add azure-resource-manager-schema to servicelinker (Azure#16176) Co-authored-by: Nan Jiang <[email protected]> * Update pr assignment config (Azure#16175) * [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (Azure#16035) * [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script * Update dataset, linked service and pipeline * Update release tag for october release * Correct type of result limit * Add arguments for SynapseSparkJobActivityTypeProperties Co-authored-by: Dongwei Wang <[email protected]> * fix (Azure#16164) Merging the change to have accurate Swagger * Remove requirement of identity field in the request for TURN. (Azure#15966) * Remove requirement of identity field in the request. * Update PR * Address comment * change api version in readme for sdk release (Azure#16187) * Add blockchain to latest profile * Add additional types * api version change Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> * [Search] Rename types for better SDK code (Azure#16039) * Rename types for better SDK code * Rename Speller and Captions search options * Reorder parameters to have consistency across APIs * Remove 'SearchIndexer' prefix from projection selectors Remove 'global' prefix from default flags on custom entities * Change enum name AdlsGen2->AzureDataLakeStorageGen2 Change property name storageContainer->storageContainerName * move additional .NET SDK renames to the REST spec * Revert changes in KnowledgeStore which has GAed * Revert changes in CustomEntityLookupSkill which has GAed * Revert changes in SIKSBlobProjectionSelector which has GAed * Revert changes in SearchIndexerDataSourceType which has GAed * Rename ignoreResetRequirements->skipIndexerResetRequirementForCache * fix validStreamingUnits (Azure#16143) Co-authored-by: Roslyn Lu <[email protected]> * Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref * add resourcemanager in module-name (Azure#16206) * add resourcemanager in module-name * add go track2 repo in readme.md * fix * Minor description update for createorupdate & update slot (Azure#15457) * add scmMinTlsVersion * modify description for createorupdate & update slot for all API versions Co-authored-by: Edwin Diaz <[email protected]> * [Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview (Azure#16096) * Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview * Updates readme * Updates API version in new specs and examples * First pass at Microsoft.Security/standards for review/preview * Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type * First pass for Microsoft.Security\standardComponents * Changes to fix a typo in an example spec * Added Microsoft.Security/standardAssignments * Fix naming convention issue * Removed types based on Hila's feedback * Changes to data model for both API calls * Fix example errors and typos * Add systemData to Microsoft.Security/standards * Changes to fix systemData linting * un-nest systemData fields in examples * More systemData placement * Naming convention name to assignments from standardAssignment * Additional example added * Changes to address descriptive comments on field types * Add systemData readOnly * prettier-fix against examples * Cleaned types to ref standard v2 common-types entry similar to securityForIoT * Re-added v2 folder? * Missed a change here? * Cleanup of v2 type completely, updated readme.md * Adds suppression to readme * Adds suppression to readme * Change modification to suppress operations linting Co-authored-by: Adam Holliday <[email protected]> * Yifanzhou/api version change (Azure#16191) * remove Catalog * update 2021-05-01-preview * delete 2021-09-01 * Update readme.md * Update purviewcatalog.json * change read-only property (Azure#16209) Co-authored-by: Parv Saxena <[email protected]> * Update account.json - make CollectionReferece type writable (Azure#16208) * Update account.json Updating the CollectionReference to be writeable to unblock the customers. * Update account.json Need the default set in the client SDK * Fixed an event name typo in its description. (Azure#16227) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview (Azure#15723) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview * Add PrivateResourceProviderConfigurations * Add PrivateRP examples * Fix enum type. * Fix enum again * Prettier * Fix prettier error * Add readme.md + prettier * Fix * Fix avocado error * Modify interface * Fix issue * Make it private preview * Remove private RP changes * Update SKU settings Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> * fluidrelay_readme_config (Azure#16192) fluidrelay_readme_config * Add community gallery proxy resource (Azure#16043) * [Hub Generated] Public private branch 'dev-storagecache-Microsoft.StorageCache-2021-09-01' (Azure#16152) * Adds base for updating Microsoft.StorageCache from version stable/2021-05-01 to version 2021-09-01 * Updates readme * Updates API version in new specs and examples * 2021-09-01 API * Fix LintDiff Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs (Azure#15946) * Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview * Change enum first letter to lower case * Change to upper case * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs * Add email reminder when PR makes changes in Synapse (Azure#16116) * add email reminder to synapse * fix for comment * ServiceBus add batch tag (Azure#16229) * add code owner to synapse (Azure#16230) * [Datafactory] Power Query model changes for multiple queries (Azure#16158) * [Synapse] Add release tag for management SDK Oct. release (Azure#16213) * update release tag * fix for avocado Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: AriZavala2 <[email protected]> Co-authored-by: PingZhu2232 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> Co-authored-by: Mohit Chakraborty <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: JiahuiPeng <[email protected]> Co-authored-by: edwin-msft <[email protected]> Co-authored-by: Edwin Diaz <[email protected]> Co-authored-by: dochollidayxx <[email protected]> Co-authored-by: Adam Holliday <[email protected]> Co-authored-by: yifan-zhou922 <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: hvermis <[email protected]> Co-authored-by: xuepingd <[email protected]> Co-authored-by: laxmankumar12 <[email protected]> Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: brpanask <[email protected]> Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> Co-authored-by: xunsun-commits <[email protected]> Co-authored-by: Wan Yang <[email protected]> Co-authored-by: soma-ms <[email protected]> * remove blank line * address comments * address the description comment * update the swagger * remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance * Update from microsoft.sql 2021-05-01-preview to base branch (Azure#16184) * Update comment.yml for publish pr (Azure#16166) * Update comment.yml * Update comment.yml * Bump dependencies (Azure#16170) * bump avocado * bump mocha * remove submodule (Azure#16171) * add azure-resource-manager-schema to servicelinker (Azure#16176) Co-authored-by: Nan Jiang <[email protected]> * Update pr assignment config (Azure#16175) * [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (Azure#16035) * [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script * Update dataset, linked service and pipeline * Update release tag for october release * Correct type of result limit * Add arguments for SynapseSparkJobActivityTypeProperties Co-authored-by: Dongwei Wang <[email protected]> * fix (Azure#16164) Merging the change to have accurate Swagger * update swagger files * update readme.md * add missing json files * update custom-words.txt to address the spelling check * remove 201 define in ServerUpdate.json * remove blank line * address comments * address the description comment * update the swagger * remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: AriZavala2 <[email protected]> Co-authored-by: PingZhu2232 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> Co-authored-by: Mohit Chakraborty <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: JiahuiPeng <[email protected]> Co-authored-by: edwin-msft <[email protected]> Co-authored-by: Edwin Diaz <[email protected]> Co-authored-by: dochollidayxx <[email protected]> Co-authored-by: Adam Holliday <[email protected]> Co-authored-by: yifan-zhou922 <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: hvermis <[email protected]> Co-authored-by: xuepingd <[email protected]> Co-authored-by: laxmankumar12 <[email protected]> Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: brpanask <[email protected]> Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> Co-authored-by: xunsun-commits <[email protected]> Co-authored-by: Wan Yang <[email protected]> Co-authored-by: soma-ms <[email protected]>

Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref

track2 arm-features

36c4e86

dw511214992 requested review from deyaaeldeen, mikeharder, mitchdenny, praveenkuttappan, qiaozha and witemple-msft as code owners July 6, 2021 06:36

dw511214992 changed the title ~~track2 arm-features~~ track2 @azure/arm-features Jul 6, 2021

deyaaeldeen reviewed Jul 6, 2021

View reviewed changes

sdk/features/arm-features/CHANGELOG.md Outdated Show resolved Hide resolved

deyaaeldeen reviewed Jul 6, 2021

View reviewed changes

sdk/features/arm-features/CHANGELOG.md Outdated Show resolved Hide resolved

deyaaeldeen reviewed Jul 6, 2021

View reviewed changes

sdk/features/arm-features/package.json Outdated Show resolved Hide resolved

remove lro

7d80ca5

dw511214992 mentioned this pull request Jul 7, 2021

[Track2] Change the tsconfig.json, package.json and README.md according to PR comments Azure/autorest.typescript#1091

Closed

dw511214992 added 2 commits July 13, 2021 10:11

Merge branch 'main' into dw/track2-arm-features

fe02a79

# Conflicts: # common/config/rush/pnpm-lock.yaml # rush.json

update

279dbca

dw511214992 requested review from ramya-rao-a, deyaaeldeen and lirenhe and removed request for mikeharder and witemple-msft July 13, 2021 02:14

dw511214992 added 4 commits July 14, 2021 17:02

Merge branch 'main' into dw/track2-arm-features

7550131

# Conflicts: # common/config/rush/pnpm-lock.yaml

update

1e9e0b6

update changelog

70fa724

update

842b104

updat e

58d39a1

sarangan12 approved these changes Jul 15, 2021

View reviewed changes

dw511214992 merged commit 16f6e54 into main Jul 15, 2021

dw511214992 deleted the dw/track2-arm-features branch July 15, 2021 03:48

deyaaeldeen pushed a commit that referenced this pull request Jul 26, 2021

track2 @azure/arm-features (#16207)

0ba023f

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 1, 2021

CodeGen from PR 16207 in Azure/azure-rest-api-specs

4e89f78

Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 1, 2021

CodeGen from PR 16207 in Azure/azure-rest-api-specs

5cf7295

Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 1, 2021

CodeGen from PR 16207 in Azure/azure-rest-api-specs

1db8d0a

Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 1, 2021

CodeGen from PR 16207 in Azure/azure-rest-api-specs

1061e20

Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 1, 2021

CodeGen from PR 16207 in Azure/azure-rest-api-specs

f783a61

Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 1, 2021

CodeGen from PR 16207 in Azure/azure-rest-api-specs

f9b29dc

Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 1, 2021

CodeGen from PR 16207 in Azure/azure-rest-api-specs

de868e7

Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

track2 @azure/arm-features #16207

track2 @azure/arm-features #16207

dw511214992 commented Jul 6, 2021

dw511214992 commented Jul 6, 2021

azure-pipelines bot commented Jul 6, 2021

deyaaeldeen Jul 6, 2021

dw511214992 Jul 7, 2021

sarangan12 Jul 9, 2021

deyaaeldeen Jul 6, 2021

dw511214992 Jul 7, 2021

sarangan12 Jul 9, 2021

deyaaeldeen Jul 9, 2021

xirzec Jul 9, 2021

witemple-msft Jul 9, 2021

deyaaeldeen Jul 9, 2021

dw511214992 commented Jul 7, 2021

azure-pipelines bot commented Jul 7, 2021

track2 @azure/arm-features #16207

track2 @azure/arm-features #16207

Conversation

dw511214992 commented Jul 6, 2021

dw511214992 commented Jul 6, 2021

azure-pipelines bot commented Jul 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dw511214992 commented Jul 7, 2021

azure-pipelines bot commented Jul 7, 2021