-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service-bus] Mitigate session-overlap test #16183
[service-bus] Mitigate session-overlap test #16183
Conversation
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
f912646
to
5eb9160
Compare
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
e1a8aac
to
67c2aca
Compare
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
… maxConcurrentCalls was passed properly. Replaced with a smaller test that can (with the right parameters, manually specified) still cause the session overlap bug. I don't have a solution for that one yet but this will allow us to investigate it when we're ready. Part of the investigation for Azure#14441
67c2aca
to
f5f5b54
Compare
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
(removing some of the debug logging I'd added in a previous PR. Prior live test run passed but I noticed it was chattier than it should have been) |
…empty entity so if the message that has been sent has not yet appeared (there can sometimes be a delay) then this test would have failed. The fix is to use one of our blocking calls (receiveMessages), put the message back and then peek.
An unrelated test failed but the assumption in it was bad (it expects to immediately peek a message after it's been sent, but there can be a delay). Fixed to receiveMessages() first, then put it back, then peekMessage(). |
/azp run js - service-bus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for handling these issues, don't be a stranger 😉
Thank you "Chris" |
Removing three tests which had more code than needed to test that the maxConcurrentCalls was passed properly.
Replaced with a smaller test that can (with the right parameters, manually specified) still cause the session overlap bug. I don't have a solution for that one yet but this will allow us to investigate it when we're ready.
Part of the investigation for #14441