Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] Mitigate session-overlap test #16183

Merged

Conversation

richardpark-msft
Copy link
Member

@richardpark-msft richardpark-msft commented Jul 2, 2021

Removing three tests which had more code than needed to test that the maxConcurrentCalls was passed properly.

Replaced with a smaller test that can (with the right parameters, manually specified) still cause the session overlap bug. I don't have a solution for that one yet but this will allow us to investigate it when we're ready.

Part of the investigation for #14441

@ghost ghost added the Service Bus label Jul 2, 2021
@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft richardpark-msft changed the title Adding in some some lower level tracking for when receiver links are … [draft] Testing session disconnect flaky test error Jul 7, 2021
@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft richardpark-msft force-pushed the sb-flakytests-sessions-new branch from f912646 to 5eb9160 Compare July 8, 2021 01:50
@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft richardpark-msft force-pushed the sb-flakytests-sessions-new branch from e1a8aac to 67c2aca Compare July 8, 2021 03:23
@richardpark-msft richardpark-msft changed the title [draft] Testing session disconnect flaky test error [service-bus] Mitigate session-overlap test Jul 8, 2021
@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

… maxConcurrentCalls was passed properly.

Replaced with a smaller test that can (with the right parameters, manually specified) still cause the session overlap bug. I don't have a solution for that one yet but this will allow us to investigate it when we're ready.

Part of the investigation for Azure#14441
@richardpark-msft richardpark-msft force-pushed the sb-flakytests-sessions-new branch from 67c2aca to f5f5b54 Compare July 8, 2021 03:50
@richardpark-msft richardpark-msft marked this pull request as ready for review July 8, 2021 03:51
@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

(removing some of the debug logging I'd added in a previous PR. Prior live test run passed but I noticed it was chattier than it should have been)

…empty entity so if the message that has been sent has not yet appeared (there can sometimes be a delay) then this test would have failed.

The fix is to use one of our blocking calls (receiveMessages), put the message back and then peek.
@richardpark-msft
Copy link
Member Author

An unrelated test failed but the assumption in it was bad (it expects to immediately peek a message after it's been sent, but there can be a delay). Fixed to receiveMessages() first, then put it back, then peekMessage().

@richardpark-msft
Copy link
Member Author

/azp run js - service-bus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for handling these issues, don't be a stranger 😉

@richardpark-msft
Copy link
Member Author

Looks good to me! Thanks for handling these issues, don't be a stranger 😉

Thank you "Chris"

@richardpark-msft richardpark-msft merged commit 121d898 into Azure:main Jul 8, 2021
@richardpark-msft richardpark-msft deleted the sb-flakytests-sessions-new branch July 8, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants