Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] - Add support for Secure Key Release #16150

Merged
merged 27 commits into from
Jul 27, 2021
Merged

[KeyVault] - Add support for Secure Key Release #16150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f2348ad
wip: live working implementation
maorleger Jun 28, 2021
c139550
update api
maorleger Jun 29, 2021
299191f
move releasepolicy to properties, start import key work
maorleger Jun 30, 2021
ca11f14
import key, add known algos, include algo in result
maorleger Jul 1, 2021
35ec817
cleanup
maorleger Jul 1, 2021
f387e4a
fetch jwt dynamically
maorleger Jul 1, 2021
dea185d
add doc comments
maorleger Jul 1, 2021
960d0b0
remove todos now that they are in PR
maorleger Jul 1, 2021
f11ced3
set soft delete retention
maorleger Jul 2, 2021
a0baf84
re-record
maorleger Jul 2, 2021
d16658d
lint fixes
maorleger Jul 2, 2021
d2b9c7b
suppress incorrect lint warning
maorleger Jul 2, 2021
b2a2daf
add new properties to deletedKey test
maorleger Jul 2, 2021
6ae1113
update attestation url
maorleger Jul 8, 2021
cedd9c3
rebase main and add changelog
maorleger Jul 13, 2021
6ff928c
add comment about issue for shared attestation resource
maorleger Jul 13, 2021
72228f7
add error cases test
maorleger Jul 16, 2021
bb82e91
recordings
maorleger Jul 16, 2021
208762f
move attestation url to env vars
maorleger Jul 16, 2021
33c6df7
update recordings, use env from recorder, and fix test values
maorleger Jul 16, 2021
497adfc
fix tests
maorleger Jul 16, 2021
01d932a
lint
maorleger Jul 16, 2021
ab0cca6
feedback
maorleger Jul 20, 2021
9da60ba
update doc-comment
maorleger Jul 20, 2021
8ee57e3
update keysModel
maorleger Jul 20, 2021
7a8743d
only return value
maorleger Jul 20, 2021
dd5ad08
update recordings and env var to match dotnet
maorleger Jul 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/keyvault/keyvault-keys/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

### Features Added

- Added support for Secure key Release from a Managed HSM.
- Added `KeyClient.releaseKey` to release a key from a Managed HSM.
- Added `exportable` and `releasePolicy` to `KeyVaultKey.properties`, `createKeyOptions`, and `importKeyOptions` in order to specify whether the key is exportable and the associated release policy.

### Breaking Changes

### Bugs Fixed
Expand Down
1 change: 1 addition & 0 deletions sdk/keyvault/keyvault-keys/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ module.exports = function(config) {
"KEYVAULT_NAME",
"KEYVAULT_URI",
"AZURE_MANAGEDHSM_URI",
"AZURE_KEYVAULT_ATTESTATION_URI",
"TEST_MODE"
],

Expand Down
119 changes: 119 additions & 0 deletions ...ons_for_managed_hsm_releasekey/recording_can_create_an_exportable_key_and_release_it.json
View file
Open in desktop

Large diffs are not rendered by default.

119 changes: 119 additions & 0 deletions ...ons_for_managed_hsm_releasekey/recording_can_import_an_exportable_key_and_release_it.json
View file
Open in desktop

Large diffs are not rendered by default.

94 changes: 94 additions & 0 deletions ...sm_releasekey/recording_errors_when_a_key_has_a_release_policy_but_is_not_exportable.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

94 changes: 94 additions & 0 deletions ...aged_hsm_releasekey/recording_errors_when_key_is_exportable_without_a_release_policy.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading