-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Analytics] Merge feature branch for v5.1.0 to main #16121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Text Analytics] Regenerate with service v3.1 swagger * export TextAnalyticsAction * move modelVersion to TextAnalyticsAction * export HealthcareEntityCategory * edit comment * edit
…15598) * [Text Analytics] add categoriesFilter * format
* [Text Analytics] Regenerate with updated swagger * add support for actionName in the response * update changelog
… suite (#15684) * [Text Analytics] Use test matrix * Move healthcare to testAnalyticsClient.spec.ts
* record tests * record browser tests * re-record * format * update to the GA versio * update README * edit * fix issue * edit * fix * fix issue * fix issue * update recordings * disable test and remove recordings
* [Text Analytics] Hide action name * format
Because the service currently support one action only per type except for PII actions. However they plan to disable multiple actions for PII as well within a month. This PR does client-side checking for this across types and throw a meaningful error message. This limitation will be relaxed in the next service preview version.
deyaaeldeen
requested review from
xirzec,
maririos,
kristapratico,
iscai-msft,
mssfang and
witemple-msft
June 30, 2021 20:57
ghost
added
the
Cognitive - Text Analytics
label
Jun 30, 2021
maririos
approved these changes
Jun 30, 2021
kristapratico
approved these changes
Jun 30, 2021
Hello @deyaaeldeen! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
feature/textanalytics/3.1
branch
June 30, 2021 23:11
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It consists of the following already-reviewed PRs:
#16114
#16095
#15995
#15684
#15649
#15598
#15554