Ensure word alpha is present in dev build #16089
Conversation
praveenkuttappan
requested review from
danieljurek,
mikeharder,
mitchdenny and
weshaggard
as code owners
|
Verified template package release using this PR. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=973452&view=logs&j=b1e79959-24d8-5aa9-2799-72d40c3e051b&t=52817674-d19f-518b-48e6-83892d5791a6 |
|
I have made the change as discussed to add a check at release time. There are few packages that doesn't get alpha build and so we shouldn't fail the build but release stage is skipped for these packages using artifact flag. |
| @@ -236,6 +236,11 @@ stages: | |||
| - ${{if ne(artifact.skipPublishDevFeed, 'true')}}: | |||
| - pwsh: | | |||
| $detectedPackageName=Get-ChildItem $(Pipeline.Workspace)/${{parameters.ArtifactName}}/${{artifact.name}}/*.tgz | |||
| if ($detectedPackageName -notmatch "-alpha") | |||
There was a problem hiding this comment.
Lets add this check in the build stage as well if SetDevVersion is set to true.
There was a problem hiding this comment.
not sure if this will happen but if the package name ends up with "-alpha" in it, this will no catch that case but I suspect that is not likely.
There was a problem hiding this comment.
We do not build alpha version of private packages so adding this check at build time will fail for them without more checks to skip them as well.
| @@ -236,6 +236,11 @@ stages: | |||
| - ${{if ne(artifact.skipPublishDevFeed, 'true')}}: | |||
| - pwsh: | | |||
| $detectedPackageName=Get-ChildItem $(Pipeline.Workspace)/${{parameters.ArtifactName}}/${{artifact.name}}/*.tgz | |||
| if ($detectedPackageName -notmatch "-alpha") | |||
| { | |||
| Write-Error "Found non alpha version artifact to publish as dev version. Failing publish step." | |||
There was a problem hiding this comment.
Probably worth dumping out the detectedPackageName as well so we have a little more information about what we found.
There was a problem hiding this comment.
Added. Link to template release pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=977617&view=logs&j=b1e79959-24d8-5aa9-2799-72d40c3e051b&t=616ae03f-d350-5ea1-2948-454bf182d472&l=12
[Hub Generated] Review request for Microsoft.Media to add version preview/2021-11-01-preview (Azure#16089) * Adds base for updating Microsoft.Media from version preview/2021-05-01-preview to version 2021-11-01-preview * Updates readme * Updates API version in new specs and examples * Update to use 2021-11-01 version of the swaggers and examples * Remove unused examples and fix prettier errors. * fix patch where required is empty. * fix some lint errors * fix a json parse issue. * fix enum casing * fix missing 204 on endpointconnections delete * create entities for Patch operation * updating descriptions * fixed a bad commit. * fix validation errors * fix few more validation issues. * fix sample validaitons * fix examples * Update PrivateEndpoints to use v3 version of commonTypes to use systemData * change all commontypes to v3 * add long running operation to operations * update missing descriptions * fix a parameter name to operationId * Update few more descriptions * adding supressions for few failed validations * fix suppreesions * add few more descriptions
Added alpha in file name filtering for dev version