Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Notes on MSAL integration in README #16076

Merged
merged 4 commits into from
Jul 7, 2021

Conversation

sadasant
Copy link
Contributor

Fixes #12669

Feedback appreciated ✨

@sadasant sadasant requested a review from scottaddie June 29, 2021 20:02
@sadasant sadasant self-assigned this Jun 29, 2021
@ghost ghost added the Azure.Identity label Jun 29, 2021
sdk/identity/identity/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/identity/identity/README.md Outdated Show resolved Hide resolved
sdk/identity/identity/README.md Outdated Show resolved Hide resolved
sdk/identity/identity/README.md Outdated Show resolved Hide resolved
sdk/identity/identity/README.md Outdated Show resolved Hide resolved
@sadasant sadasant marked this pull request as ready for review June 30, 2021 01:08
@sadasant sadasant requested a review from scottaddie June 30, 2021 13:22
@ramya-rao-a
Copy link
Contributor

@sadasant, @scottaddie,

Please take a look at the discussion in #12565 to see if we have missed addressing anything

@sadasant
Copy link
Contributor Author

@ramya-rao-a In this PR we’re mainly trying to express how we use MSAL. Should we also include information about ms-rest-* libraries?

sdk/identity/identity/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/identity/identity/README.md Outdated Show resolved Hide resolved
sdk/identity/identity/README.md Outdated Show resolved Hide resolved
sdk/identity/identity/README.md Outdated Show resolved Hide resolved
sdk/identity/identity/README.md Outdated Show resolved Hide resolved
@sadasant sadasant requested a review from scottaddie July 6, 2021 12:30
Copy link
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sadasant sadasant merged commit 8d6a8cd into Azure:main Jul 7, 2021
@sadasant sadasant deleted the identity/fix12669 branch July 7, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Identity] Notes on MSAL integration in README
3 participants