[ContainerRegistry] doc improvements #16021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@maorleger Can you review this please? |
maorleger
approved these changes
Aug 9, 2021
to keep three images instead of four
maorleger
approved these changes
Aug 16, 2021
| @@ -31,7 +31,7 @@ async function main() { | |||
| let imageCount = 0; | |||
| // Delete images older than the first three. | |||
| for await (const manifest of imageManifests) { | |||
| if (imageCount++ > imagesToKeep) { | |||
| if (imageCount++ >= imagesToKeep) { | |||
There was a problem hiding this comment.
for clarity I would recommend just incrementing imageCount separately but up to you
ckairen
pushed a commit
to ckairen/azure-sdk-for-js
that referenced
this pull request
Aug 24, 2021
* Add example code snippets to update*Properties() ref doc * Add comments about `orderBy` options in README * Fix tags * Correct deleteImages sample code to keep three images instead of four * Address CR feedback * Update CHANGELOG for beta.4 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16096