Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Monitor Exporter] Separate tests into internal and public folders #15932

Merged
merged 12 commits into from
Jun 28, 2021
Merged

[Azure Monitor Exporter] Separate tests into internal and public folders #15932

merged 12 commits into from
Jun 28, 2021

Conversation

xiao-lix
Copy link
Contributor

@xiao-lix xiao-lix commented Jun 23, 2021 •
edited
Loading

@ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jun 23, 2021
@xiao-lix xiao-lix requested a review from KarishmaGhiya June 23, 2021 22:59
@xiao-lix xiao-lix requested a review from benbp as a code owner June 24, 2021 00:33
@xiao-lix xiao-lix changed the title [Monitor Exporter] Separate tests into internal and public folders [Azure Monitor Exporter] Separate tests into internal and public folders Jun 24, 2021
@xiao-lix
Copy link
Contributor Author

/azp run js - monitor-opentelemetry-exporter - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

hectorhdzg
hectorhdzg approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@hectorhdzg hectorhdzg merged commit df68c3e into Azure:main Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

@benbp benbp Awaiting requested review from benbp

Assignees
No one assigned
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiao-lix @hectorhdzg