-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Update @azure/core-tracing to use @opentelemetry/[email protected] #15883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel great about updating OT to 1.0, and I think I'm okay with getting core-tracing finally out of preview too.
@ramya-rao-a @chradek do you feel good about this?
we could put out another preview of core-tracing (against OTel 1.0.0) in July and then just do a pure version bump to GA it in august if that feels better? Edit to add: chatted with @xirzec offline and we will release one more preview - preview.12 - which upgrades |
@@ -93,7 +93,7 @@ | |||
"dependencies": { | |||
"@azure/abort-controller": "^1.0.0", | |||
"@azure/core-auth": "^1.3.0", | |||
"@azure/core-tracing": "1.0.0-preview.12", | |||
"@azure/core-tracing": "1.0.0-preview.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to call out this change, which I discovered in #15881 - because core-client is still depending on core-rest-pipeline 1.0.3 we cannot take this change in yet. Downgrading here means that all corev2 packages are on the same version of core-tracing.
I am hopeful though that by this release we can take core-rest-pipeline 1.1.0 GA and put all our dependencies on the same version!
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
d55ec86
to
71500cd
Compare
I agree on doing GA for core-tracing later in August. We can use the time in July to see what else we want to change before GA |
Now that
@opentelemetry/api
GA'd at 1.0.0 we can bump our owncore-tracing package to 1.0.0 as well.
Reminder: not all packages are on the latest @opentelemetry/api... those that depend on @azure/core-rest-pipeline cannot be
upgraded yet.