Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic rush update #15839

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Automatic rush update #15839

merged 1 commit into from
Jun 18, 2021

Conversation

azure-sdk
Copy link
Collaborator

Automatic rush update PR

@azure-sdk azure-sdk force-pushed the automated-rush-update branch from ce012f9 to 6205381 Compare June 18, 2021 03:18
ramya-rao-a
ramya-rao-a reviewed Jun 18, 2021
View reviewed changes
common/config/rush/pnpm-lock.yaml
@@ -1378,7 +1378,7 @@ packages:
/@types/body-parser/1.19.0:
dependencies:
'@types/connect': 3.4.34
'@types/node': 8.10.66
'@types/node': 15.12.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @types/node version keeps changing based on whose machine the rush update PRs usually come from. Anybody know the mystery here? Or is ti just dependent on the version of node on the PR author's machine?

cc @xirzec, @chradek

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it should not be dependent on the version of node on the author's machine because that doesn't have any influence on the types.

My pet theory was that the author may have inadvertently pulled in a new version while working in the repo across branches, but this is presumably happening now from freshly cloning the repo!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we go with this change and then wait and watch what happens next :)

Assuming we will have automated PRs going forward, it should stay the same

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some transitive dependencies are pulling it in? I'm fine approving this for now

@azure-sdk azure-sdk force-pushed the automated-rush-update branch from 6205381 to 6eb10ce Compare June 18, 2021 18:51
@praveenkuttappan
Copy link
Member

/check-enforcer evaluate

@praveenkuttappan
Copy link
Member

/check-enforcer reset

@praveenkuttappan
Copy link
Member

/check-enforcer evaluate

@praveenkuttappan
Copy link
Member

/check-enforcer override

@praveenkuttappan praveenkuttappan merged commit c075155 into Azure:main Jun 18, 2021
@ramya-rao-a ramya-rao-a mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chradek chradek chradek approved these changes

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@xirzec xirzec xirzec approved these changes

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

@mikeharder mikeharder Awaiting requested review from mikeharder

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azure-sdk @praveenkuttappan @xirzec @ramya-rao-a @chradek