Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Identity version in attestation package to 2.0.0-beta.4 #15708

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Update Identity version in attestation package to 2.0.0-beta.4 #15708

merged 3 commits into from
Jun 11, 2021

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Jun 11, 2021 •
edited
Loading

Update identity to 2.0.0-beta.4 for @azure/attestation

Related epic - #14581

Instructions:

  • tenantId now can't be an invalid tenantId, so use the recorder's replaceableVariables to set one like 12345678-1234-1234-1234-123456789012.
  • Ensure the recorder automatically replaces the value for client-request-id on the outgoing requests to a non-variable value. The latest recorder on master should automatically do this, but please verify.
  • Re-record the NodeJS tests, since MSAL does some more recordings (one of them being that they verify that the Identity endpoint is available, which is something our previous Identity client didn't do).

@KarishmaGhiya KarishmaGhiya mentioned this pull request Jun 11, 2021
Closed
@KarishmaGhiya KarishmaGhiya added Attestation Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jun 11, 2021
@KarishmaGhiya KarishmaGhiya added this to the [2021] July milestone Jun 11, 2021
@KarishmaGhiya
Copy link
Member Author

KarishmaGhiya commented Jun 11, 2021 •
edited
Loading

@sadasant Do you know about these failures? The recorded tests pass on local - in both live and record mode.

@jeremymeng - I think you faced the same issue for container registry. How did that get fixed?

@KarishmaGhiya KarishmaGhiya changed the base branch from master to update-identity-attestation June 11, 2021 23:43
@KarishmaGhiya KarishmaGhiya merged commit 4cf1e12 into Azure:update-identity-attestation Jun 11, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
@madhude
CodeGen from PR 15708 in Azure/azure-rest-api-specs
482e4d9 
Adding 2021-07-01 version in recoveryservices, recoveryservicessiterecovery folder to make it S360 compliant (Azure#15708)

* Adding a new API version 2021-07-01 to make recoveryservices and recoveryservicessiterecovery RP same as recoveryservicesbackup

* Updating readme.md file

* Resolved PR comments

* Fixing Avocado failures

Co-authored-by: Madhumanti Dey <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
@madhude
CodeGen from PR 15708 in Azure/azure-rest-api-specs
2b90d5a 
Adding 2021-07-01 version in recoveryservices, recoveryservicessiterecovery folder to make it S360 compliant (Azure#15708)

* Adding a new API version 2021-07-01 to make recoveryservices and recoveryservicessiterecovery RP same as recoveryservicesbackup

* Updating readme.md file

* Resolved PR comments

* Fixing Avocado failures

Co-authored-by: Madhumanti Dey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarryOsterman LarryOsterman LarryOsterman left review comments

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

Assignees

@LarryOsterman LarryOsterman

Labels
Attestation Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] July
Development

Successfully merging this pull request may close these issues.
2 participants
@KarishmaGhiya @LarryOsterman