[KeyVault] - Return void from delete methods #15642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorleger
requested review from
bterlson,
chradek,
sadasant and
xirzec
as code owners
ghost
added
the
xirzec
approved these changes
Jun 9, 2021
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jun 21, 2021
## What -KeyVaultAccessControlClient#deleteRoleAssignment changes to return `Promise<void>` instead of `Promise<RestResponse>` -KeyVaultAccessControlClient#deleteRoleDefinition changes to return `Promise<void>` instead of `Promise<RestResponse>` ## Why Originally we wanted to return the raw response so that customers can access the headers / status code / etc. However, with the upcoming effort to core-v2 returning a raw response today would require us to make a breaking change tomorrow as corev2 does not return the raw response, using a callback instead. By returning `Promise<void>` today we will be ready to change to corev2 tomorrow without introducing a breaking change to these methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
-KeyVaultAccessControlClient#deleteRoleAssignment changes to return
Promise<void>instead ofPromise<RestResponse>-KeyVaultAccessControlClient#deleteRoleDefinition changes to return
Promise<void>instead ofPromise<RestResponse>Why
Originally we wanted to return the raw response so that customers can access the headers / status code / etc. However, with the
upcoming effort to core-v2 returning a raw response today would require us to make a breaking change tomorrow as corev2
does not return the raw response, using a callback instead.
By returning
Promise<void>today we will be ready to change to corev2 tomorrow without introducing a breaking change tothese methods.