Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on dropping support for non LTS versions of Node.js #15627

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

ramya-rao-a
Copy link
Contributor

This PR updates our support policy regarding dropping support for non LTS versions of Node.js

@check-enforcer
Copy link

check-enforcer bot commented Jun 8, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@ramya-rao-a
Copy link
Contributor Author

/check-enforcer override

@ramya-rao-a ramya-rao-a merged commit 555449f into Azure:master Jun 9, 2021
@ramya-rao-a ramya-rao-a deleted the support branch June 9, 2021 00:11
sadasant pushed a commit to sadasant/azure-sdk-for-js that referenced this pull request Jun 21, 2021
…5627)

* Add note on dropping support for non LTS versions of Node.js

* Azure SDK libraries for JavaScript

* Add link to support doc from readme
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Sep 14, 2021
[SRP] 2021-06-01 Swagger Api (Azure#15627)

* Add June21 Swagger Api version, Updated Readme files

* adding abort and hnson migration swagger API

* swagger: marking requesttype as required parameter for hns onmigration

* Added new PublicNetworkAccess property to swagger spec

* Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger

* Add Account Level VLW Swagger changes and example

* Update Blob Inventory Api comment to include AccessTierInferred and Tags

* Rename HnsOn to hierarchical namespace

* [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec

* Update Spell check custom words list. Correct incorrect spellings

* Add missing refrences to PublicNetworkAccess Examples

* Add required type:object, Add default return type for hns migration apis

* Prettier tool update to storage.json

* Add update account with immutability policy example

* Removed StorageFileDataSmbShareOwner as Server side does not support it

* Add AllowProtectedAppendWritesAll feature changes with example

* Updated enum values and description for PublicNetworkAccess

* Add type:object to ProtectedAppendWritesHistory ; Spellcheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants