Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] ManagedIdentityCredential also supports app registration client IDs #15518

Merged

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Jun 2, 2021

Recently a customer of our JS SDK had some issues with the ManagedIdentityCredential. As we helped them, it became clear that part of the problem was that they wouldn’t assume passing an app registration client ID would work since the documentation only refers to user assigned managed identity, for example: .NET docs link.

More specifically, here’s their docs feedback: #15221 (comment)

This PR is to extend the current documentation to directly mention that app registrations are supported.

If approved:
Fixes: #15221

Any and all feedback appreciated!

@sadasant sadasant self-assigned this Jun 2, 2021
@sadasant sadasant requested a review from witemple-msft as a code owner June 2, 2021 20:28
@ghost ghost added the Azure.Identity label Jun 2, 2021
@ramya-rao-a
Copy link
Contributor

@sadasant, Please log issues in the .NET, Python and Java repos to ensure respective package owners can check if they need to make similar updates

@check-enforcer

This comment has been minimized.

@sadasant
Copy link
Contributor Author

sadasant commented Jun 8, 2021

@schaabs I’ve added more information regarding AKS. Please review again!

@ramya-rao-a I’ve made issues for .NET, Python and Java:

@sadasant sadasant requested a review from schaabs June 8, 2021 20:28
@sadasant sadasant merged commit e258a77 into Azure:master Jun 10, 2021
@sadasant sadasant deleted the identity/MIC-app-registration-client-id branch June 10, 2021 23:07
sadasant added a commit to sadasant/azure-sdk-for-js that referenced this pull request Jun 21, 2021
…lient IDs (Azure#15518)

* Idea on how to improve the related docs

* feedback from Scott

* specifically referencing to AKS pod-identity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*Credential.getToken support for clientID and tenantId
3 participants