[Communication]: Add SDK operation to exchange access token #15449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thdinizm
requested review from
0rland0Wats0n,
ankitarorabit,
bterlson,
chradek,
DominikMe,
xirzec and
a team
as code owners
ghost
added
the
beltr0n
requested changes
May 27, 2021
sdk/communication/communication-identity/test/public/communicationIdentityClient.mocked.spec.ts
Show resolved
Hide resolved
|
Just curious, if this is for private preview, should we keep the package version at 1.0.1? I'm not sure who the ask is from for this |
|
looks like we also need Changelog.md to be updated |
beltr0n
approved these changes
May 28, 2021
beltr0n
requested changes
May 28, 2021
...mmunication/communication-identity/test/public/node/exchangeAADtokenForACStoken.node.spec.ts
Outdated
Show resolved
Hide resolved
...mmunication/communication-identity/test/public/node/exchangeAADtokenForACStoken.node.spec.ts
Outdated
Show resolved
Hide resolved
|
/azp run js - communication-identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/communication/communication-identity/review/communication-identity.api.md
Outdated
Show resolved
Hide resolved
|
Hello @thdinizm! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
beltr0n
approved these changes
May 28, 2021
ghost
merged commit
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 30, 2021
Update readme.python.md (Azure#15449) * Update readme.python.md * Create readme.python.md
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new operation to exchange an AAD token for ACS token:
exchangeTokenmethod into public client