Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-amqp] improve doc comment for AcquireLockProperties.abortSignal #15417

Merged
merged 1 commit into from
Jun 4, 2021
Merged

[core-amqp] improve doc comment for AcquireLockProperties.abortSignal #15417

merged 1 commit into from
Jun 4, 2021

Conversation

chradek
Copy link
Contributor

@chradek chradek commented May 26, 2021

My attempt at improving the doc comments based on feedback: #15349 (review)

The CancellableAsyncLockImpl.acquire() should mention that the behavior for both abort and timeout are the same (they only are in effect prior to the inner task being invoked). It's clear for task but not for abort.

@ghost ghost added the Azure.Core label May 26, 2021
@chradek chradek mentioned this pull request May 26, 2021
Merged
richardpark-msft
richardpark-msft approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

The comment is merely icing on the cake - that is a really neat addition to the locking.

@ramya-rao-a
Copy link
Contributor

@chradek Can we merge this?

@chradek chradek merged commit 5b401ee into Azure:master Jun 4, 2021
@chradek chradek deleted the core-amqp-improve-lock-doc branch June 4, 2021 02:21
@chradek
Copy link
Contributor Author

chradek commented Jun 4, 2021

Sorry, missed the notification on this.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 2, 2021
CodeGen from PR 15417 in Azure/azure-rest-api-specs
cad8e43 
[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-08-01 (Azure#15417)

* Adds base for updating Microsoft.Cache from version stable/2021-03-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Breaking Change: Replaced 'sasUri' import parameter with 'sasUris' to enable importing from multiple files

* Fix ModelValidation errors and some existing Linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpark-msft richardpark-msft richardpark-msft approved these changes

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chradek @ramya-rao-a @richardpark-msft