Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure AccessTokens are interpreted as milliseconds-since-epoch values. #15100

Merged
2 commits merged into from
Apr 30, 2021

Conversation

MalcolmTyrrell
Copy link
Member

JWT expiry values are in seconds-since-epoch whereas JS Dates are in milliseconds-since-epoch.

Copy link
Contributor

@craigktreasure craigktreasure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@ghost
Copy link

ghost commented Apr 30, 2021

Hello @MalcolmTyrrell!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e25f57e into Azure:master Apr 30, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jul 15, 2021
Adding compute 2021-04-01 version (Azure#15100)

* initial copy of old files to new folder 2021-04-01

* api version update

* Add SpotRestorePolicy to CRP's VM Scale Set Resource (Azure#14692)

* Resolve merge conflicts after branch recreation

* Fix Lint error

* update with changes mae in 2021-03-01

* Update compute.json

* Update CreateAVmWithNetworkInterfaceConfiguration.json

update example file also to fix breaking change naming issue.

* Feature/cplat 2021 04 01 - Capacity Reservation related changes (Azure#15058)

* updated code

* updated swagger with cr changes

* updated swagger with cr changes

* updated swagger with cr changes

* updated swagger

* updated swagger

* updated swagger

* Feature/cplat 2021 04 01 (Azure#15070)

* 2021-04 initial

* 2021-04 examples and readme

* adding CR VMSS changes

* updating api version in example and description of CR profile

Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>

* Update compute.json

* syncronizing 2021-04-01 swagger with changes made in 2021-03-01

Co-authored-by: Sandeep Vishnu <[email protected]>
Co-authored-by: hari-bodicherla <[email protected]>
Co-authored-by: micahjo <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants