-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Targeting Filter introduced in the sample-react. #15088
Conversation
Thank you for your contribution rivohra! We will review the pull request and get back to you soon. |
add track 2 configurations for web (Azure#15088)
setFeature2({ enabled: setting2.enabled && withinRange }); | ||
} | ||
} | ||
if (isFeatureFlag(setting3)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs updates based on the latest API design.
@HarshaNalluru Looks like @rivohra has not responded here. If the changes you need are trivial, can you push the changes to this branch to get this PR updated? |
Hi @rivohra. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @rivohra. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
Targeting filter is used for rolling out the feature to a certain percentage of entire user base, to certain users and groups. In the sample, Another action (Feature 3 - Targeting)" button in the dropdown will be enabled based on the targeting parameters from the client filter. For different users, results will be different based on the rollout percentage.
Issue #14969