Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Device Models Repository Client #14863
Create Device Models Repository Client #14863
Changes from 31 commits
f19be7a
be96c30
bdfc7fd
3f9798a
8219fa9
7e15c99
438238f
da8a359
b537e91
117b6ba
f0c69e1
4fca643
3f7c510
c48dd65
b755192
5589e21
6e78c4e
0407787
d20073c
a9ee639
84e25d9
9686d19
9650a3e
bd9e9c4
d17b3a6
635fe5b
6d99014
7e33fd2
98904a5
f4e6792
a393f91
76ac761
54a6be1
513fb55
7207a5f
cc50153
38ff0f3
aa8f0cd
684f954
83446b2
cf9c75a
8326da7
63828a0
99a5ed5
dd61713
f8daa06
bcfc92f
a6fab62
e34ed32
7d06b30
88dc580
a2804b4
e9ac523
3393208
18ff958
b006c90
5d836c3
86a0a1d
92f6998
1702077
c9300eb
1a16b3b
c8d840a
ed45199
c61bdd5
b3a9d2e
3bc841a
9cd6f42
c2a5da1
734bda0
14a1861
c6b2e0e
8a8360d
1e3e54c
fd28662
e4e0aad
cd32118
3c0ba8f
09500de
3479f5f
7558cd8
626fccd
96505be
471acf5
897c899
20a7b3c
a80e4a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the package name should be updated to
@azure/iot-models-repository
. The typical convention is to use dashes to separate words in package names (e.g.iot-device-update
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you for the typical convention, but to follow the same naming convention for the existing models repository clients in other languages, (see python), keeping it as
@azure/iot-modelsrepository
will maintain cross language consistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we care about 'cross language consistency' for package names? The package names are already quite different for assembly-based systems like C# and Java. I don't think JS customers care about Python package naming conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got feedback from the SDK review board to use
modelsrepository
as the service name. We are trying to be consistent across language SDKs to make it easier to find the package/code.I see other JS packages not using that convention eg: @azure/servicefabric
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is not a track 2 library. Every track 2 package in https://github.com/Azure/azure-sdk-for-js/blob/master/rush.json appears to use dash as a separator.
Do you believe that folks searching npm won't find
models-respository
overmodelsrepository
? I would imagine folks would search with a space, and most indexers break on-
but would have more trouble doing prefix searches for partial matches.