Updating clean commands for Communication package #14708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KarishmaGhiya
commented
Apr 5, 2021
KarishmaGhiya
commented
- Updating "clean" commands to reflect the new browser output folder mapping i.e. dist-test/** instead of test-dist or test-browser/** Also updated some of the left-over rollup-config commands. Addresses the issue - [Service Bus] Browser tests are not running #14437 and partly - Review and fix inconsistencies in the package.json scripts and rollup/karma/.d.ts-types configurations across the repo #13387
- Opening new PR to avoid triggering more pipelines as part of this PR - update clean commands #14693
Co-authored-by: Harsha Nalluru <[email protected]>
…a/azure-sdk-for-js into update-package-json
KarishmaGhiya
requested review from
richardpark-msft,
sadasant,
sarangan12,
schaabs,
southpolesteve,
vinjiang,
vishnureddy17,
witemple-msft,
XiaoningLiu,
xirzec,
zfoster and
a team
as code owners
ghost
added
Azure.Core
App Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.