Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication]: Updated versions for GA release #14487

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

lsundaralingam
Copy link
Member

  • PhoneNumbers will be shipped as preview
  • Everything else moves to GA (1.0.0)

Copy link
Member

@JoshuaLai JoshuaLai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@DominikMe DominikMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lakshman!
There are some more version constants that need to be updated, the JS repo is a little complicated unfortunately :-)

sdk/communication/communication-identity/CHANGELOG.md Outdated Show resolved Hide resolved
@@ -1,6 +1,6 @@
{
"name": "@azure/communication-chat",
"version": "1.0.0-beta.6",
"version": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more changes that need to be made for each package.

package-version: This is either in package.json or in the README.md for swagger. Here it's on line 11.
Then we should re-gen with autorest.

@LuChen-Microsoft @juancamilor Did we lock the swagger url for Chat to point to the spec repo? We can't point to the int-gateway hosted file anymore.

SDK_Version constant:
There's a version in contants.ts for each package that needs updating to 1.0.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominikMe the PR for the specs is going through. Will update all sdks when is approved (hopefully today/tomorrow)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juancamilor Can we update the README to point to the latest commit in the PR of the specs repo?
A moving target for the swagger has been a common problem with Chat because we who are outside of the Chat team can't confidently re-generate the code.
We've tried it before to just update the packageVersion for the user agent but the re-gen'd code would have a lot of changes as work has happened in the gateway. That's why we pin swagger commits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramya-rao-a
Copy link
Contributor

Hello!

Can someone please look at the below issues before releasing the packages?

@DominikMe
Copy link
Member

@ramya-rao-a
For #14312 we don't consider it release blocking for beta - we're skipping smoke tests and can't turn them on until the underlying backend services support better testability.

#14501 to fix the other issue

@ramya-rao-a
Copy link
Contributor

Sounds good, thanks @DominikMe

@ramya-rao-a
Copy link
Contributor

For #14312 we don't consider it release blocking for beta - we're skipping smoke tests and can't turn them on until the underlying backend services support better testability.

Please do make sure that the smoke tests are enabled before we ship GA for the phone numbers package

@lsundaralingam
Copy link
Member Author

/azp run js - communication - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@DominikMe DominikMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! ✅

@DominikMe DominikMe enabled auto-merge (squash) March 25, 2021 23:42
@DominikMe DominikMe merged commit ec7794d into Azure:master Mar 25, 2021
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants