-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Communication]: Updated versions for GA release #14487
Conversation
lsundaralingam
commented
Mar 24, 2021
- PhoneNumbers will be shipped as preview
- Everything else moves to GA (1.0.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lakshman!
There are some more version constants that need to be updated, the JS repo is a little complicated unfortunately :-)
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@azure/communication-chat", | |||
"version": "1.0.0-beta.6", | |||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more changes that need to be made for each package.
package-version
: This is either in package.json or in the README.md for swagger. Here it's on line 11.
Then we should re-gen with autorest.
@LuChen-Microsoft @juancamilor Did we lock the swagger url for Chat to point to the spec repo? We can't point to the int-gateway hosted file anymore.
SDK_Version
constant:
There's a version in contants.ts for each package that needs updating to 1.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DominikMe the PR for the specs is going through. Will update all sdks when is approved (hopefully today/tomorrow)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juancamilor Can we update the README to point to the latest commit in the PR of the specs repo?
A moving target for the swagger has been a common problem with Chat because we who are outside of the Chat team can't confidently re-generate the code.
We've tried it before to just update the packageVersion for the user agent but the re-gen'd code would have a lot of changes as work has happened in the gateway. That's why we pin swagger commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DominikMe The change for swagger url is already merged into master.
https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/communication/communication-chat/swagger/README.md
Hello! Can someone please look at the below issues before releasing the packages? |
@ramya-rao-a #14501 to fix the other issue |
Sounds good, thanks @DominikMe |
eed7a98
to
1bbc946
Compare
Please do make sure that the smoke tests are enabled before we ship GA for the phone numbers package |
/azp run js - communication - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! ✅
update azureml job examples (Azure#14487)