[Service Bus] Update perf tests to use a single sender for all instances #14460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
HarshaNalluru
commented
Mar 24, 2021
HarshaNalluru
commented
- Imports v7 in the v1 tests to allow creating the resources
- Makes sender static in both v1 and v7
HarshaNalluru
requested review from
chradek,
ramya-rao-a and
richardpark-msft
as code owners
ghost
added
the
| @@ -8,6 +8,7 @@ | |||
| "license": "ISC", | |||
| "dependencies": { | |||
| "@azure/service-bus": "^1.1.10", | |||
| "@azure/service-bus-v7": "npm:@azure/service-bus@^7.0.3", | |||
There was a problem hiding this comment.
Wow, did not know you could do this!
There was a problem hiding this comment.
Learned it yesterday! :)
All hail npm! All hail SOF!!!
|
|
||
| export abstract class ServiceBusTest<TOptions> extends PerfStressTest<TOptions> { | ||
| sbClient: ServiceBusClient; | ||
| static sbClient: ServiceBusClient = new ServiceBusClient(connectionString); |
There was a problem hiding this comment.
Any reason not to do this in globalSetup()?
There was a problem hiding this comment.
Doesn't matter. It would work the same way.
In my mind.. I've kept globalSteup for creating the resources and the initialization of clients at the static variable declaration itself.
richardpark-msft
approved these changes
Mar 24, 2021
|
@HarshaNalluru Can this be merged? |
|
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
…ces (Azure#14460) - Imports v7 in the v1 tests to allow creating the resources - Makes sender static in both v1 and v7
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.