Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventGrid] Mappings for new ACS Events #14410

Merged
merged 4 commits into from
Mar 23, 2021
Merged

[EventGrid] Mappings for new ACS Events #14410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2c47af
[EventGrid] Fix ACS Event Names
ellismg Mar 22, 2021
d184be3
[EventGrid] Add types for RecordingFileStatusUpdated event
ellismg Mar 22, 2021
142fc41
[EventGrid] Remove incorrect ACS System Events
ellismg Mar 23, 2021
46dcf78
Update sdk/eventgrid/eventgrid/CHANGELOG.md
ellismg Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sdk/eventgrid/eventgrid/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@

## 4.1.0 (Unreleased)

- Add `Microsoft.Communication.ChatThreadParticipantAdded` and `Microsoft.Communication.ChatThreadParticipantRemoved` to the list of System Event types. These replace
`Microsoft.Communication.ChatParticipantAddedToThread` and `Microsoft.Communication.ChatParticipantRemovedFromThread` respectively. Azure Communication Services no
longer sends events with these older names.
- The syetem event names `Microsoft.Communication.ChatParticipantAddedToThread` and `Microsoft.Communication.ChatParticipantRemovedFromThread` have been removed, and
ellismg marked this conversation as resolved.
Show resolved Hide resolved
`Microsoft.Communication.ChatThreadParticipantAdded` and `Microsoft.Communication.ChatThreadParticipantRemoved` have been added. The old names did not match the
the type names that Azure Communication Services was using for these events. TypeScript users will now see compliation errors if they are calling `isSystemEvent` with
either `Microsoft.Communication.ChatParticipantAddedToThread` or `Microsoft.Communication.ChatParticipantRemovedFromThread` as the event name. To fix these issues,
replace all uses of `Microsoft.Communication.ChatParticipantAddedToThread` with `Microsoft.Communication.ChatThreadParticipantAdded` and
`Microsoft.Communication.ChatParticipantRemovedFromThread` with `Microsoft.Communication.ChatThreadParticipantRemoved`.

- Add `Microsoft.Communications.RecordingFileStatusUpdated` system event.

## 4.0.0 (2021-03-17)
Expand Down
4 changes: 0 additions & 4 deletions sdk/eventgrid/eventgrid/review/eventgrid.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,11 +1194,7 @@ export interface SystemEventNameToEventData {
"Microsoft.Communication.ChatMessageDeleted": AcsChatMessageDeletedEventData;
"Microsoft.Communication.ChatMessageEdited": AcsChatMessageEditedEventData;
"Microsoft.Communication.ChatMessageReceived": AcsChatMessageReceivedEventData;
// @deprecated
"Microsoft.Communication.ChatParticipantAddedToThread": AcsChatParticipantAddedToThreadEventData;
"Microsoft.Communication.ChatParticipantAddedToThreadWithUser": AcsChatParticipantAddedToThreadWithUserEventData;
// @deprecated
"Microsoft.Communication.ChatParticipantRemovedFromThread": AcsChatParticipantRemovedFromThreadEventData;
"Microsoft.Communication.ChatParticipantRemovedFromThreadWithUser": AcsChatParticipantRemovedFromThreadWithUserEventData;
"Microsoft.Communication.ChatThreadCreatedWithUser": AcsChatThreadCreatedWithUserEventData;
"Microsoft.Communication.ChatThreadParticipantAdded": AcsChatParticipantAddedToThreadEventData;
ellismg marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
10 changes: 0 additions & 10 deletions sdk/eventgrid/eventgrid/src/predicates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,20 +128,10 @@ export interface SystemEventNameToEventData {
"Microsoft.Communication.ChatThreadWithUserDeleted": AcsChatThreadWithUserDeletedEventData;
/** An interface for the event data of a "Microsoft.Communication.ChatThreadPropertiesUpdatedPerUser" event. */
"Microsoft.Communication.ChatThreadPropertiesUpdatedPerUser": AcsChatThreadPropertiesUpdatedPerUserEventData;
/** An interface for the event data of a "Microsoft.Communication.ChatParticipantAddedToThread" event.
*
* @deprecated since 4.1.0. Azure Communication Services no longer uses this event name. Please use Microsoft.Communication.ChatThreadParticipantAdded instead.
*/
"Microsoft.Communication.ChatParticipantAddedToThread": AcsChatParticipantAddedToThreadEventData;
/** An interface for the event data of a "Microsoft.Communication.ChatThreadParticipantAdded" event. */
"Microsoft.Communication.ChatThreadParticipantAdded": AcsChatParticipantAddedToThreadEventData;
/** An interface for the event data of a "Microsoft.Communication.ChatParticipantAddedToThreadWithUser" event. */
"Microsoft.Communication.ChatParticipantAddedToThreadWithUser": AcsChatParticipantAddedToThreadWithUserEventData;
/** An interface for the event data of a "Microsoft.Communication.ChatParticipantRemovedFromThread" event.
*
* @deprecated since 4.1.0. Azure Communication Services no longer uses this event name. Please use Microsoft.Communication.ChatThreadParticipantRemoved instead.
*/
"Microsoft.Communication.ChatParticipantRemovedFromThread": AcsChatParticipantRemovedFromThreadEventData;
/** An interface for the event data of a "Microsoft.Communication.ChatThreadParticipantRemoved" event. */
"Microsoft.Communication.ChatThreadParticipantRemoved": AcsChatParticipantRemovedFromThreadEventData;
/** An interface for the event data of a "Microsoft.Communication.ChatParticipantRemovedFromThreadWithUser" event. */
Expand Down