update test-browser output folder #14384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KarishmaGhiya
commented
Mar 19, 2021
•
KarishmaGhiya
commented
- Making test browser output folder consistent [Test] browser test ouput folder consistency issue #8844
KarishmaGhiya
requested review from
bterlson,
chradek,
daviwil,
ellismg,
HarshaNalluru,
jeremymeng,
maorleger,
ramya-rao-a,
richardpark-msft,
sadasant,
schaabs,
witemple-msft and
xirzec
as code owners
ghost
added
Azure.Core
App Configuration
|
@HarshaNalluru Can you take a first look at this PR? |
| "test:browser": "npm run clean && npm run build:test:browser && npm run unit-test:browser", | ||
| "test:node": "npm run clean && npm run build:test:node && npm run unit-test:node", | ||
| "test": "npm run test:node && npm run test:browser", | ||
| "unit-test:browser": "", | ||
| "unit-test:node": "npm run build:test:node && mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace test-dist/index.node.js", | ||
| "unit-test:node": "npm run build:test:node && mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace \"test-dist/index.node.js\"", |
There was a problem hiding this comment.
Suggested change
| "unit-test:node": "npm run build:test:node && mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace \"test-dist/index.node.js\"", | |
| "unit-test:node": "npm run build:test:node && mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace \"dist-test/index.browser.js\"", |
There was a problem hiding this comment.
@KarishmaGhiya Can you fix the build failures?
There was a problem hiding this comment.
Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
I am getting these errors - I'll check if there's an issue with Devops
Co-authored-by: Harsha Nalluru <[email protected]>
|
/azp run js - appconfiguration - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
KarishmaGhiya
commented
Mar 20, 2021
witemple-msft
approved these changes
Mar 22, 2021
KarishmaGhiya
requested review from
EmmaZhu,
jiacfan,
ljian3377,
vinjiang and
XiaoningLiu
as code owners
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
May 12, 2021
Update ServiceBus.json (Azure#14384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.