Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rush version to 5.40.7 #14202

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

praveenkuttappan
Copy link
Member

Upgrade rush version to latest rush version to build all dependent packages. Latest version of rush identifies transitive dependency when --from flag is used.

I will wait until March release is over to merge this change.

Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the core - ci pipeline is passing. The test build is failing on Node 8.

@praveenkuttappan
Copy link
Member Author

praveenkuttappan commented Mar 18, 2021

Latest rush version finds nd include all dependent packages in all type of dependencies. So this makes ESLint plugin project also eligible to test and as @deyaaeldeen said, ESLint plugin cannot be tested on Node 8 and rush doesn't have an option to exclude a specific project(I can't find any such option) so it fails on Node 8. We will have to put this on hold until we either make eslint run on Node 8 or we drop node 8 testing or rush adds an option to exclude a specific project.

FYI: @ramya-rao-a, @mikeharder, @deyaaeldeen, @richardpark-msft

This is resolved.

@praveenkuttappan
Copy link
Member Author

/azp run js - template

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - identity

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - identity

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - template

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - storage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - keyvault

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - appconfiguration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - communication

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - textanalytics

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - appconfiguration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - app-configuration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - storage-blob - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/azp run js - eslint-plugin - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants