-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rush version to 5.40.7 #14202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once the core - ci
pipeline is passing. The test build is failing on Node 8.
Latest rush version finds nd include all dependent packages in all type of dependencies. So this makes ESLint plugin project also eligible to test and as @deyaaeldeen said, ESLint plugin cannot be tested on Node 8 and rush doesn't have an option to exclude a specific project(I can't find any such option) so it fails on Node 8. We will have to put this on hold until we either make eslint run on Node 8 or we drop node 8 testing or rush adds an option to exclude a specific project. FYI: @ramya-rao-a, @mikeharder, @deyaaeldeen, @richardpark-msft This is resolved. |
/azp run js - template |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - identity |
Azure Pipelines successfully started running 1 pipeline(s). |
c39c4dd
to
1cd848c
Compare
/azp run js - identity |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - template |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - storage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - keyvault |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - appconfiguration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - communication |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - textanalytics |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - appconfiguration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - app-configuration - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - storage-blob - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - eslint-plugin - ci |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Upgrade rush version to latest rush version to build all dependent packages. Latest version of rush identifies transitive dependency when --from flag is used.
I will wait until March release is over to merge this change.