[Communication] SMS 1:N Messages - Update Samples #14125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
beltr0n
requested review from
lsundaralingam,
minnieliu,
paolamvhz,
JoshuaLai,
RezaJooyandeh,
0rland0Wats0n and
ankitarorabit
beltr0n
changed the title
|
Closing temporarily, making some changes to be more consistent with other sdks |
|
/check-enforcer reset |
|
/azp run js - communication - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
minnieliu
approved these changes
Mar 8, 2021
| message: "Hello World via SMS!" // The message being sent | ||
| }, | ||
| { | ||
| enableDeliveryReport: true, | ||
| tag: "customTag" | ||
| tag: "TypeScriptSMSSample" |
There was a problem hiding this comment.
In C#, the message and tag are related so that users can get an idea of how to use the tag. (e.g. Message is "Weekly Promotion", and tag is "marketing". Wondering if we should do something here as well.
There was a problem hiding this comment.
will do, @lsundaralingam can you do that for python too then?
JoshuaLai
approved these changes
Mar 8, 2021
lsundaralingam
approved these changes
Mar 8, 2021
DominikMe
reviewed
Mar 8, 2021
| @@ -62,33 +63,70 @@ npm install @azure/identity | |||
| ``` | |||
|
|
|||
| The [`@azure/identity`][azure_identity] package provides a variety of credential types that your application can use to do this. The README for @azure/identity provides more details and samples to get you started. | |||
| AZURE_CLIENT_SECRET, AZURE_CLIENT_ID and AZURE_TENANT_ID environment variables are needed to create a DefaultAzureCredential object. | |||
There was a problem hiding this comment.
That's not really the case. Environment variables are only one way of how to use the DefaultAzureCredential
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
May 28, 2021
[Hub Generated] Public private branch 'master' (Azure#14125) * Swager specs for Sentinel Source Control RP API * Remove unnecessary space. * Fix avocado * Fix SemanticValidation-Error * Fix LintDiff * add new api and change api version * correct some merge error * merge to master * Avoid breaking change * Add RepoList definition. * Fix prettier issue. * Fix prettier issue. * Fix model validation issue. * Fix model validation issue. * Fix SDK Track2 validation. * Reference common ResourceWithEtag. * Fix LintDiff issue. * Fix LintDiff issue. * repository properties. * fix regression. * Fix reference. * Fix lintDiff issue. * using POST command instead of GET to retrieve repository metadata * Fix ModelValidation error. * Incorporate comments. * remove duplicate systemData in SourceControl. * add POST verb. * Revert an unnecessary change. * Fix error caused by merging. * Revert an unreviewed change. * Update API response. * Fix typo. * Update swagger definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding samples and updating README for the new SMS Changes