Sync eng/common directory with azure-sdk-tools for PR 1447 #14023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove BuildType parameter as we can default it from package properties - Stop passing BuildType and GroupId and instead defaul them from package properties - Enable StrictMode to help identify potential errors - Start passing sdktype and isnewsdk properties to devops script - Sync latest changes with devops work item to fix a couple bugs
azure-sdk
requested review from
danieljurek,
mikeharder,
mitchdenny,
praveenkuttappan and
weshaggard
as code owners
azure-sdk
added
Central-EngSys
weshaggard
approved these changes
Feb 27, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
May 11, 2021
PR for new api-version: Microsoft.Cache/redis/stable/2020-12-01 [rebased + refactored] (Azure#14023) * Adds base for updating Microsoft.Cache from version stable/2020-06-01 to version 2020-12-01 * Updates readme * Updates API version in new specs and examples * Adding Redis Version to PUT request (Azure#12675) * Adding Redis Version to PUT request * Include RedisVersion in PUT and PATCH, and update description to clarify major version * Adding new properties isPrimary and replicasPerPrimary (Azure#13005) * Adding new properties isPrimary and replicasPerPrimary * Addressing PR feedback Co-authored-by: Lavanya Singampalli <[email protected]> * Refactor the latest redis.json API spec proposal to use the definitions ProxyResource, TrackedResource and OperationListResult from common-types/resource-management/v2. (I hope CI likes this!) * Cleanup now-unreferenced #definitions which were still flagged as duplicate definitions. * Fix linter errors for camelCasing of API names and formatting of integer types. * Fix more linter errors by adding pagable, refactoring LinkedServers and FirewallRules. These will be between-versions breaking changes for the SDK, in the name of more API consistency. * Fix linter error 'PUT' operation 'PrivateEndpointConnections_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. * Fix some duplicate example names. * Revert "Fix linter error 'PUT' operation 'PrivateEndpointConnections_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change." -- because it introduces new linter errors. * Revert "Fix more linter errors by adding pagable, refactoring LinkedServers and FirewallRules. These will be between-versions breaking changes for the SDK, in the name of more API consistency." This reverts commit c0e305128834947066bb59de2c4247b29feef5ee. * Fix the example name for CheckNameAvailability. * Add x-ms-pageable suggested by the linter. * Revert the linter fix for CheckNameAvailabiltiy camelCasing to avoid introducing new linter errors. * Use same FirewallRule response schema for PUT and GET, addressing linter errors, and have RedisFirewallRuleCreateParameters inherit it in hopes that helps with SDK backcompat. * Fix indenting. * Fix broken $ref reference syntax. * Add back the description for RedisFirewallRuleCreateParameters. * Actually run prettier. * With print width 20 * Suppress the warnings that booleans are not descriptive, since to change them would be a breaking change. * Delete unintended extra character * Revert enum type-hinting and refactors to common-types that are getting flagged as breaking changes. * Add back the refactorings to use Resource/ProxyResource/TrackedResource from common-types. Since otherwise we get "Duplicate Schema named Resource -- properties.id.description: undefined => "Fully qualified resource ID for the resource. Ex - /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/resourceProviderNamespace/resourceType/resourceName", properties.name.description: undefined => "The name of the resource"," Co-authored-by: MECHANDR <[email protected]> Co-authored-by: lasingam <[email protected]> Co-authored-by: Lavanya Singampalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1447 See eng/common workflow