Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[communication] new phone numbers library #14012

Merged
merged 20 commits into from
Mar 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7254fb1
[communication] new phone numbers package (#13349)
0rland0Wats0n Jan 26, 2021
edb9c4b
.
0rland0Wats0n Feb 3, 2021
46d50d2
Merge branch 'master' of github.com:Azure/azure-sdk-for-js into featu…
0rland0Wats0n Feb 3, 2021
2b2b693
Merge branch 'master' of github.com:Azure/azure-sdk-for-js into featu…
0rland0Wats0n Feb 3, 2021
91e5dc8
[communication] update new phone numbers client (#13560)
0rland0Wats0n Feb 16, 2021
563af57
[communication] disable extensible enums (#13806)
0rland0Wats0n Feb 17, 2021
558787f
[communication] new phone numbers package (#13349)
0rland0Wats0n Jan 26, 2021
e295831
[communication] update new phone numbers client (#13560)
0rland0Wats0n Feb 16, 2021
2517025
[communication] disable extensible enums (#13806)
0rland0Wats0n Feb 17, 2021
50a0f75
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
0rland0Wats0n Feb 24, 2021
6814d92
[communication] add samples to readme (#13957)
0rland0Wats0n Feb 25, 2021
12fbe6f
Merge branch 'feature/communication/new-phone-numbers' of github.com:…
0rland0Wats0n Feb 25, 2021
37725f7
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
0rland0Wats0n Feb 26, 2021
9b8b9e6
[communication] regenerate client from latest swagger (#13976)
0rland0Wats0n Feb 26, 2021
c1e1a8f
add space
0rland0Wats0n Mar 2, 2021
9742717
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
0rland0Wats0n Mar 2, 2021
b2c39a2
get lock file from master and build
0rland0Wats0n Mar 2, 2021
429c6fc
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
0rland0Wats0n Mar 8, 2021
7246fc0
Update package.json
0rland0Wats0n Mar 8, 2021
a43046e
rebuild
0rland0Wats0n Mar 8, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
668 changes: 660 additions & 8 deletions common/config/rush/pnpm-lock.yaml

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions rush.json
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,11 @@
"projectFolder": "sdk/communication/communication-identity",
"versionPolicyName": "client"
},
{
"packageName": "@azure/communication-phone-numbers",
"projectFolder": "sdk/communication/communication-phone-numbers",
"versionPolicyName": "client"
},
{
"packageName": "@azure/communication-sms",
"projectFolder": "sdk/communication/communication-sms",
Expand Down
2 changes: 2 additions & 0 deletions sdk/communication/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,5 @@ extends:
safeName: azurecommunicationchat
- name: azure-communication-identity
safeName: azurecommunicationidentity
- name: azure-communication-phone-numbers
safeName: azurecommunicationphonenumbers
2 changes: 2 additions & 0 deletions sdk/communication/communication-phone-numbers/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/**/code-model-v*
/docGen
10 changes: 10 additions & 0 deletions sdk/communication/communication-phone-numbers/.nycrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"include": ["dist-esm/src/**/*.js"],
"exclude": ["**/*.d.ts", "dist-esm/src/generated/*"],
"reporter": ["text-summary", "html", "cobertura"],
"exclude-after-remap": false,
"sourceMap": true,
"produce-source-map": true,
"instrument": true,
"all": true
}
42 changes: 42 additions & 0 deletions sdk/communication/communication-phone-numbers/.vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new guidline? A lot of other libraries include a launch.json and it's useful for debugging in vscode.

// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Debug Mocha Test [Without Rollup]",
"program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
"args": [
"-r",
"ts-node/register",
"--timeout",
"999999",
"--colors",
"${workspaceFolder}/test/*.spec.ts"
],
"env": { "TS_NODE_COMPILER_OPTIONS": "{\"module\": \"commonjs\"}" },
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
"protocol": "inspector"
},
{
"type": "node",
"request": "launch",
"name": "Debug Unit Tests",
"program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
"args": [
"-u",
"tdd",
"--timeout",
"999999",
"--colors",
"${workspaceFolder}/dist-test/index.node.js"
],
"internalConsoleOptions": "openOnSessionStart",
"preLaunchTask": "npm: build:test"
}
]
}
5 changes: 5 additions & 0 deletions sdk/communication/communication-phone-numbers/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Release History

## 1.0.0-beta.4 (Unreleased)

The Azure Communication Phone Numbers Client library contains code which facilitates phone number management.
21 changes: 21 additions & 0 deletions sdk/communication/communication-phone-numbers/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
The MIT License (MIT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still shipping the license with the package, right? Are there work items that licenses need to be removed for all services?


Copyright (c) 2020 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
Loading