[communication] regenerate client from latest swagger #13976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0rland0Wats0n
requested review from
bterlson,
chradek and
xirzec
as code owners
ghost
added
the
DominikMe
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Lgtm, one comment where the generator changed the location follow logic.
Also, let's try to use a shipped version of autorest instead of the private drop once ready. The autorest PR to track is here: Azure/autorest.typescript#871
sdk/communication/communication-phone-numbers/src/generated/src/operations/phoneNumbers.ts
Show resolved
Hide resolved
also validates that change to lro code from regen does not break lros that worked before
0rland0Wats0n
requested review from
danieljurek,
daviwil,
deyaaeldeen,
ellismg,
EmmaZhu,
HarshaNalluru,
jeremymeng,
jiacfan,
joheredi,
sophiajt,
KarishmaGhiya,
ljian3377,
maorleger,
mikeharder,
mitchdenny,
praveenkuttappan,
qiaozha,
ramya-rao-a and
richardpark-msft
as code owners
0rland0Wats0n
requested review from
sadasant,
sarangan12,
schaabs,
southpolesteve,
vinjiang,
weshaggard,
witemple-msft,
XiaoningLiu,
zfoster and
a team
as code owners
…Azure/azure-sdk-for-js into update-swagger
DominikMe
pushed a commit
that referenced
this pull request
Mar 8, 2021
* [communication] new phone numbers package (#13349) * [communication] update new phone numbers client (#13560) * [communication] disable extensible enums (#13806) * [communication] new phone numbers package (#13349) * [communication] update new phone numbers client (#13560) * [communication] disable extensible enums (#13806) * [communication] add samples to readme (#13957) * [communication] regenerate client from latest swagger (#13976) * regenerate client from latest swagger * update autorest/ts version also validates that change to lro code from regen does not break lros that worked before * add space * get lock file from master and build * Update package.json * rebuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR regenerates the generated client from the latest swagger. It also defines a new interface
SearchAvailablePhoneNumbersRequest.