Verify api file path and enable api-extractor for abort-controller #13861
Conversation
praveenkuttappan
requested review from
bterlson,
chradek,
danieljurek,
mikeharder,
mitchdenny,
weshaggard and
xirzec
as code owners
ghost
added
the
praveenkuttappan
added
the
Central-EngSys
| { | ||
| Write-Host "$($packageDir) should contain only one api review for $($packageName)" | ||
| Write-Host "No of Packages $($files.Count)" | ||
| Write-Host "$($pkgName) does not have api review json" |
There was a problem hiding this comment.
What if anything should folks do if they hit this issue?
There was a problem hiding this comment.
Log an issue to get the api review file in.
We have #13387 that should fix this up across the repo. cc @KarishmaGhiya
We have the code generator now using the api extractor, so any newly generated package should have this.
Anybody using our template project as a reference should also get it
There was a problem hiding this comment.
I mainly asked the question here as I think we need to improve the message here to let folks know what they should do if they hit this.
There was a problem hiding this comment.
Agreed. How about
THIS IS BAD! LOG A GITHUB ISSUE FOR THIS NOW!!!!
:)
There was a problem hiding this comment.
Updated log message
There was a problem hiding this comment.
In addition to this change, I will check if we can update client type for util package to different type after March release. I will create and issue for tracking.There is an alternate thread on this discussion.
|
@praveenkuttappan You will have to commit the api review file generated with this PR and the build will pass. Run "rushx build" for this package on your local and commit the api file. |
| onabort?: (ev?: Event) => any; | ||
| dispatchEvent(_event: Event): boolean; | ||
| static get none(): AbortSignal; | ||
| onabort: ((ev?: Event) => any) | null; |
There was a problem hiding this comment.
the only minor eyebrow raise here is the switch from onabort being optional to requiring null.
Looks like @daviwil did this 2 years ago though, so probably it's fine?
Enable API extractor for abort controller and also check API extract file path