Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keySize override from createRsaKeyOptions #13684

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Remove keySize override from createRsaKeyOptions #13684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f4ffe
Remove keySize override
maorleger Feb 9, 2021
fb25423
update api
maorleger Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/keyvault/keyvault-keys/review/keyvault-keys.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ export interface CreateOctKeyOptions extends CreateKeyOptions {
// @public
export interface CreateRsaKeyOptions extends CreateKeyOptions {
hsm?: boolean;
keySize?: number;
publicExponent?: number;
}

Expand Down
6 changes: 1 addition & 5 deletions sdk/keyvault/keyvault-keys/src/keysModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ export interface CreateKeyOptions extends coreHttp.OperationOptions {
*/
readonly expiresOn?: Date;
/**
* Size of the key
* The key size in bits. For example: 2048, 3072, or 4096 for RSA.
*/
keySize?: number;
}
Expand Down Expand Up @@ -345,10 +345,6 @@ export interface CreateEcKeyOptions extends CreateKeyOptions {
* passed to {@link createRsaKey}
*/
export interface CreateRsaKeyOptions extends CreateKeyOptions {
/**
* The key size in bits. For example: 2048, 3072, or 4096 for RSA.
*/
keySize?: number;
/**
* Whether to import as a hardware key (HSM) or software key.
*/
Expand Down